Merge lp:~saviq/unity8/fix-indicator-tests into lp:unity8

[Michał Sawicz]

Wait for the indicator to appear.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes. The test completes again.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[Albert Astals Cid (aacid)]

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, tests passed here

* Did CI run pass? If not, please explain why.
Wait, should pass...

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/unity8-ci/2235/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2910
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2652/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/757
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/759
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/759/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/757
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2912
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2912/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2653
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2653/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5078/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3638

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2235/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Ok, it improves by 1

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/unity8-ci/2240/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2936
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2674
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1111
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/762
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/764
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/764/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/762
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2575
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2938
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2938/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2675
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2675/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5099
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3666

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2240/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/unity8-ci/2253/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/2972
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2705
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1124
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/777
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/777/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/775
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2611
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2974
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/2974/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2706
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2706/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5129
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3705

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2253/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/unity8/shell/emulators/main_window.py'
--- tests/autopilot/unity8/shell/emulators/main_window.py	2013-11-26 21:12:27 +0000
+++ tests/autopilot/unity8/shell/emulators/main_window.py	2014-02-05 11:47:25 +0000
@@ -92,7 +92,7 @@
         return self.app.select_single(objectName="pinentryField")
 
     def get_indicator(self, indicator_name):
-        return self.app.select_single(
+        return self.app.wait_select_single(
             'DefaultIndicatorWidget',
             objectName=indicator_name+'-widget'
         )