Merge lp:~saviq/unity8/fix-dashshown-test into lp:unity8

Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 553
Merged at revision: 553
Proposed branch: lp:~saviq/unity8/fix-dashshown-test
Merge into: lp:unity8
Diff against target: 12 lines (+3/-0)
1 file modified
tests/qmltests/tst_Shell.qml (+3/-0)
To merge this branch: bzr merge lp:~saviq/unity8/fix-dashshown-test
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+196690@code.launchpad.net

Commit message

Wait for DashHome to be available in tst_Shell.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

lgtm.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:553
http://jenkins.qa.ubuntu.com/job/unity8-ci/1740/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/1126/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/1109
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/423
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/263
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/264
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/264/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/263
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/1001/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1126
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/1126/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1109
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/1109/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3679
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/1790

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/1740/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qmltests/tst_Shell.qml'
2--- tests/qmltests/tst_Shell.qml 2013-11-08 02:21:09 +0000
3+++ tests/qmltests/tst_Shell.qml 2013-11-26 10:29:30 +0000
4@@ -72,6 +72,9 @@
5 ok = homeLoader !== undefined
6 && homeLoader.item !== undefined;
7
8+ var dashHome = findChild(shell, "DashHome");
9+ ok &= dashHome !== undefined;
10+
11 var greeter = findChild(shell, "greeter");
12 ok &= greeter !== undefined;
13

Subscribers

People subscribed via source and target branches