Merge lp:~saviq/unity8/drop-scopes-env into lp:unity8

Proposed by Michał Sawicz on 2015-04-21
Status: Merged
Approved by: Albert Astals Cid on 2015-04-27
Approved revision: 1733
Merged at revision: 1761
Proposed branch: lp:~saviq/unity8/drop-scopes-env
Merge into: lp:unity8
Diff against target: 14 lines (+0/-5)
1 file modified
data/unity8-dash.conf (+0/-5)
To merge this branch: bzr merge lp:~saviq/unity8/drop-scopes-env
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve on 2015-04-27
Paweł Stołowski 2015-04-21 Approve on 2015-04-27
PS Jenkins bot continuous-integration Needs Fixing on 2015-04-21
Review via email: mp+256962@code.launchpad.net

Commit Message

UNITY_SCOPES_LIST is no more

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * Did you make sure that your branch does not contain spurious tags?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Paweł Stołowski (stolowski) wrote :

+1

review: Approve
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Not really much to test since we were not using this anyway

 * Did CI run pass?
AP got broken, but it's a common issue, not here

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/unity8-dash.conf'
2--- data/unity8-dash.conf 2014-10-24 18:40:40 +0000
3+++ data/unity8-dash.conf 2015-04-21 15:43:07 +0000
4@@ -18,11 +18,6 @@
5 env APP_ID=unity8-dash
6
7 pre-start script
8- if [ -z "$UNITY_SCOPES_LIST" ]; then
9- # FIXME: remove once we have this in dconf
10- initctl set-env UNITY_SCOPES_LIST="clickscope;musicaggregator;videoaggregator"
11- fi
12-
13 initctl emit scope-ui-starting
14 end script
15

Subscribers

People subscribed via source and target branches