Merge lp:~saviq/unity/phablet.unlock-on-focus into lp:unity/phablet

Proposed by Michał Sawicz
Status: Merged
Approved by: Michael Zanetti
Approved revision: no longer in the source branch.
Merged at revision: 698
Proposed branch: lp:~saviq/unity/phablet.unlock-on-focus
Merge into: lp:unity/phablet
Diff against target: 27 lines (+6/-0)
2 files modified
Shell.qml (+3/-0)
debian/changelog (+3/-0)
To merge this branch: bzr merge lp:~saviq/unity/phablet.unlock-on-focus
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+165989@code.launchpad.net

Commit message

hide greeter onFocusRequested to unlock on accepted incoming call

Description of the change

To improve the incoming call behaviour, for now let's hide the greeter when there's a new app coming to focus.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

8 + // TODO: this should be protected to only unlock for certain applications / certain usecases
9 + // potentially only in connection with a notification

Hmm... I think the unlocking of the greeter is ok. I guess once my Lockscreens are landed we could elevate certain apps (like the phone-app) on top of the Lockscreen for the duration of the phone call and then move it back behind the lock screen.

Revision history for this message
Michael Zanetti (mzanetti) wrote :

for now definitely ok I'd say...

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Shell.qml'
2--- Shell.qml 2013-05-24 08:00:04 +0000
3+++ Shell.qml 2013-05-28 08:43:29 +0000
4@@ -82,6 +82,9 @@
5 target: applicationManager
6 ignoreUnknownSignals: true
7 onFocusRequested: {
8+ // TODO: this should be protected to only unlock for certain applications / certain usecases
9+ // potentially only in connection with a notification
10+ greeter.hide();
11 shell.activateApplication(desktopFile);
12 }
13 }
14
15=== modified file 'debian/changelog'
16--- debian/changelog 2013-05-24 13:16:26 +0000
17+++ debian/changelog 2013-05-28 08:43:29 +0000
18@@ -7,6 +7,9 @@
19 * Add i18n support.
20 * Add libc6-dev to Build-Depends.
21
22+ [ Michał Sawicz ]
23+ * Unlock onFocusRequested to unlock on incoming call (LP: #1181654).
24+
25 -- Sergio Schvezov <sergio.schvezov@canonical.com> Wed, 22 May 2013 17:34:27 -0300
26
27 qml-phone-shell (1.77) raring; urgency=low

Subscribers

People subscribed via source and target branches