Unity

Merge lp:~saviq/unity/phablet.release-172 into lp:unity/phablet

  1. phablet.release-172
  2. Merge into phablet
Proposed by Michał Sawicz
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp:~saviq/unity/phablet.release-172
Merge into: lp:unity/phablet
Prerequisite: lp:~mzanetti/unity/phablet-hide-static-apps-while-search
Diff against target: 39 lines (+32/-0)
1 file modified
debian/changelog (+32/-0)
To merge this branch: bzr merge lp:~saviq/unity/phablet.release-172
Reviewer Review Type Date Requested Status
Michi Henning (community) Needs Information
PS Jenkins bot (community) continuous-integration Approve
Sergio Schvezov Needs Fixing
Albert Astals Cid Pending
Michael Zanetti Pending
Review via email: mp+159881@code.launchpad.net

Commit message

release 1.72

  * bring greeter closer to desktop design
  * simplify SortFilterProxyModel role management
  * CMake and build script improvements
  * enable volume slider in Overview
  * clean up .bzrignore
  * flatten qmluitests and unittests into generic qmltests
  * split out LimitProxyModel out of SortFilterProxyModel
  * replace fake QML wrappers for Ubuntu.Application with a mock
    implementation
  * hide Frequent and Available categories in Apps lens during search
    (LP: #1170495)
  * add first test utilities
  * use fake Unity plugin for Dash tests
  * generate and package API docs
  * close applications after long-press in dash
  * simplify preview calculation
  * tests for:
    * bad indentation
    * Panel
    * indicators Overview
    * IndicatorItem
    * ListViewWithPageHeader
    * Clock
    * OpenEffect
    * FilterGrids
    * MenuContent
    * header standalone compilation

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:615
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/675/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/unity-phablet-qmluitests/484/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/677
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/677/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/675
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/551
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/551/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1201

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/675/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

It really looks good, but let's push this directly into raring.

quantal is cherry pick only now and we can live with this bug since we are switching current to raring on Monday.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:615
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/722/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/546
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/724/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/598
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/598/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/602
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1264

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/722/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:615
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/726/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/551
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/728
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/728/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/726
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/602
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/602/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/606
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1268

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/726/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Hey guys, please test on device and release if everything's ok.

Revision history for this message
Michi Henning (michihenning) wrote :

When I run build_unity, I get an error:

libtool: install: (cd /home/michi/src/unity_build/libunity/src; /bin/bash /home/michi/src/unity_build/libunity/libtool --silent --tag CC --mode=relink gcc -version-info 9:2:0 -export-symbols-regex "^unity_.*" -o libunity.la -rpath /home/michi/src/phablet.release-172/../unity_build/build/lib libunity_la-unity-trace.lo libunity_la-unity-appinfo-manager.lo libunity_la-unity-icon.lo libunity_la-unity-inspector.lo libunity_la-unity-io.lo libunity_la-unity-launcher.lo libunity_la-unity-lens.lo libunity_la-unity-lens-activation.lo libunity_la-unity-lens-category.lo libunity_la-unity-lens-filters.lo libunity_la-unity-lens-merge-strategy.lo libunity_la-unity-lens-preferences-manager.lo libunity_la-unity-lens-private.lo libunity_la-unity-lens-search.lo libunity_la-unity-lens-tools.lo libunity_la-unity-previews.lo libunity_la-unity-scope.lo libunity_la-unity-scope-factory.lo libunity_la-unity-scope-private.lo libunity_la-unity-scope-proxy.lo libunity_la-unity-scope-proxy-local.lo libunity_la-unity-scope-proxy-remote.lo libunity_la-unity-sound-menu.lo libunity_la-unity-sound-menu-mpris.lo -lglib-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgee -lgobject-2.0 -lglib-2.0 -pthread -ldee-1.0 -lgthread-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -ldbusmenu-glib ../protocol/libunity-protocol-private.la )
 /usr/bin/install -c -m 644 unity.h '/home/michi/src/phablet.release-172/../unity_build/build/include/unity/unity'
 /bin/mkdir -p '/home/michi/src/phablet.release-172/../unity_build/build/lib/girepository-1.0'
 /bin/mkdir -p '/home/michi/src/phablet.release-172/../unity_build/build/share/gir-1.0'
 /usr/bin/install -c -m 644 Unity-6.0.gir '/home/michi/src/phablet.release-172/../unity_build/build/share/gir-1.0'
 /usr/bin/install -c -m 644 Unity-6.0.typelib '/home/michi/src/phablet.release-172/../unity_build/build/lib/girepository-1.0'
/usr/bin/ld: cannot find -lunity-protocol-private
collect2: error: ld returned 1 exit status
libtool: install: error: relink `libunity.la' with the above command before installing it
make[3]: *** [install-libLTLIBRARIES] Error 1

After building, which works, and the tests all pass, when I try to run on the desktop, I get this (presumably because of the earlier error):

$ ./run
QML debugging is enabled. Only use this in a safe environment.
Module 'HudClient' does not contain a module identifier directive - it cannot be protected from external registrations.
file:///home/michi/src/phablet.release-172/Shell.qml:140:9: Type Dash unavailable
             Dash {
             ^
file:///home/michi/src/phablet.release-172/Dash/Dash.qml:19:1: plugin cannot be loaded for module "Unity": Cannot load library /home/michi/src/phablet.release-172/builddir/plugins/Unity/libUnity-qml.so: (libunity-protocol-private.so.0: cannot open shared object file: No such file or directory)
     import Unity 0.1
     ^

Revision history for this message
Michi Henning (michihenning) wrote :
Download full text (3.3 KiB)

There are tons more errors during the unity build after the first one, for example:

Configuring Unity..
mkdir: cannot create directory ‘/home/michi/src/phablet.release-172/../unity_build/unity/build’: File exists
-- Using precompiled headers.
Unity is configured with support for X.org
-- GSettings schemas will be installed into /home/michi/src/unity_build/build/share/glib-2.0/schemas/
-- Configuring done
-- Generating done
-- Build files have been written to: /home/michi/src/unity_build/unity/build
Building UnityCore and installing in /home/michi/src/phablet.release-172/../unity_build/build
[ 0%] Built target unity-core-6.0_pch
[ 0%] [ 0%] [ 0%] Building CXX object UnityCore/CMakeFiles/unity-core-6.0.dir/ApplicationPreview.cpp.o
Building CXX object UnityCore/CMakeFiles/unity-core-6.0.dir/GenericPreview.cpp.o
Building CXX object UnityCore/CMakeFiles/unity-core-6.0.dir/Lens.cpp.o
/home/michi/src/unity_build/unity/UnityCore/ApplicationPreview.cpp:21:28: fatal error: unity-protocol.h: No such file or directory
compilation terminated.
/home/michi/src/unity_build/unity/UnityCore/GenericPreview.cpp:21:28: fatal error: unity-protocol.h: No such file or directory
compilation terminated.
/home/michi/src/unity_build/unity/UnityCore/Lens.cpp:25:28: fatal error: unity-protocol.h: No such file or directory
compilation terminated.

The interesting thing is that build_unity seems to finish normally and returns zero exit status:

-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-client/api-index-full.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-client/libhud-client.devhelp2
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/object-tree.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/libhud-gtk-HudGtkManager.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/left.png
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/index.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/deprecated-api-index.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/index.sgml
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/annotation-glossary.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/style.css
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/libhud-gtk.devhelp2
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/ch01.html
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/home.png
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/up.png
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/right.png
-- Installing: /home/michi/src/unity_build/build/share/gtk-doc/html/libhud-gtk/api-index-full.html
Linking system lenses..

So, unless I pay attention as all the noise flies past, I'm under the impression that everything worked just fine. The unity...

Read more...

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:617
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/748/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/583
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/750
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-armhf-ci/750/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-quantal-i386-ci/748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/624
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/624/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/628
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1296

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/748/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

After re-downloading all of unity and re-running build_unity, it works again. Maybe build_unity -u doesn't update everything it should? Of maybe, after updating, build_unity doesn't build everything it should?

Anyway, it works now.

Revision history for this message
Michi Henning (michihenning) wrote :

When I run "make alltests", I get six failures:

FAIL! : qmltestrunner::PeoplePreview::test_stuff(One Number) Could not click on Message field
FAIL! : qmltestrunner::PeoplePreview::test_stuff(Three Numbers) Could not click on phone field
FAIL! : qmltestrunner::PeoplePreview::test_stuff(Only Mails) Could not click on field Generic_QMLTYPE_11(0x9f49e0, "emailField0")
FAIL! : qmltestrunner::PeoplePreview::test_stuff(Only IM) Could not click on field Generic_QMLTYPE_11(0xc325e0, "imField0")
FAIL! : qmltestrunner::PeoplePreview::test_stuff(Std Contact) Could not click on Message field
FAIL! : qmltestrunner::PeoplePreview::test_stuff(Std + Status) Could not click on Message field

Are these expected?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

The test passed in CI [1], it also passes on my machine ($builder -C builddir testPeoplePreview) after an initial failure:

FAIL! : qmltestrunner::PeoplePreview::test_stuff(One Number) Could not click on Message field
   Actual (): 0
   Expected (): 1
   Loc: [/home/michal/dev/canonical/phablet/manhattan/repo/tests/qmltests/Dash/tst_PeoplePreview.qml(249)]

A dozen or so subsequent runs passes completely. The test might need improvement indeed.

[1] https://jenkins.qa.ubuntu.com/job/unity-phablet-ci/748/testReport/%28root%29/qmltestrunner/PeoplePreview__test_stuff/?

Revision history for this message
Michi Henning (michihenning) wrote :

I'm also seeing this:

Built target testIndicatorRow
Scanning dependencies of target testHud
Module 'HudClient' does not contain a module identifier directive - it cannot be protected from external registrations.

(process:12256): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:12256): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

(process:12256): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:12256): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

(process:12256): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:12256): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

(process:12256): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:12256): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

(process:12256): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(process:12256): GLib-GObject-CRITICAL **: g_signal_connect_data: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed
file:///home/michi/src/phablet.release-172/Hud/HudParametrizedActionsPage.qml:138:5: QML Item: Binding loop detected for property "width"
file:///home/michi/src/phablet.release-172/Components/PageHeader.qml:47:5: QML Connections: Cannot assign to non-existent property "onShownChanged"

review: Needs Information
Revision history for this message
Michi Henning (michihenning) wrote :

There is also plenty of other noise in the output. I have no idea what it means and whether it's supposed to be there. But, in general, the noise makes it hard to decide whether things are working. Here is one example:

Built target testGreeter
Scanning dependencies of target testIndicators
Module 'Ubuntu.ChewieUI' does not contain a module identifier directive - it cannot be protected from external registrations.
file:///home/michi/src/phablet.release-172/Components/Revealer.qml:95: TypeError: Cannot set property 'y' of null
file:///home/michi/src/phablet.release-172/Components/PageHeader.qml:47:5: QML Connections: Cannot assign to non-existent property "onShownChanged"
file:///home/michi/src/phablet.release-172/Components/Revealer.qml:93: TypeError: Cannot set property 'y' of null
file:///home/michi/src/phablet.release-172/Panel/Menus/Overview/VolumeWidget.qml:63: ReferenceError: volumeControl is not defined
file:///home/michi/src/phablet.release-172/Components/PageHeader.qml:48: ReferenceError: greeter is not defined
file:///home/michi/src/phablet.release-172/Components/Revealer.qml:84:36: TypeError: Result of expression is not an object
file:///home/michi/src/phablet.release-172/Components/Revealer.qml:85:21: TypeError: Result of expression is not an object
file:///usr/share/themes/Ambiance/qmltheme/TextAreaDelegate.qml:44: Unable to assign [undefined] to QObject*
file:///usr/share/themes/Ambiance/qmltheme/TextAreaDelegate.qml:49: Unable to assign [undefined] to QObject*

Revision history for this message
Albert Astals Cid (aacid) wrote :

Michi the tests succeed, so it's ok, if the test failed it'd say "FAIL!" and a summary of the failed tests

Revision history for this message
Albert Astals Cid (aacid) wrote :

Since we need a raring release rejecting this one and switching to https://code.launchpad.net/~mzanetti/unity/phablet-release-172/+merge/160578

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-11 15:12:12 +0000
3+++ debian/changelog 2013-04-23 22:32:27 +0000
4@@ -1,3 +1,35 @@
5+qml-phone-shell (1.72) quantal; urgency=low
6+
7+ * bring greeter closer to desktop design
8+ * simplify SortFilterProxyModel role management
9+ * CMake and build script improvements
10+ * enable volume slider in Overview
11+ * clean up .bzrignore
12+ * flatten qmluitests and unittests into generic qmltests
13+ * split out LimitProxyModel out of SortFilterProxyModel
14+ * replace fake QML wrappers for Ubuntu.Application with a mock
15+ implementation
16+ * hide Frequent and Available categories in Apps lens during search
17+ (LP: #1170495)
18+ * add first test utilities
19+ * use fake Unity plugin for Dash tests
20+ * generate and package API docs
21+ * close applications after long-press in dash
22+ * simplify preview calculation
23+ * tests for:
24+ * bad indentation
25+ * Panel
26+ * indicators Overview
27+ * IndicatorItem
28+ * ListViewWithPageHeader
29+ * Clock
30+ * OpenEffect
31+ * FilterGrids
32+ * MenuContent
33+ * header standalone compilation
34+
35+ -- Michał Sawicz <michal.sawicz@canonical.com> Fri, 19 Apr 2013 21:16:50 +0200
36+
37 qml-phone-shell (1.71) quantal; urgency=low
38
39 * add missing python3 dependency

Subscribers

People subscribed via source and target branches