Merge lp:~saviq/unity/phablet.protect-local-build-revisions into lp:unity/phablet

Proposed by Michał Sawicz
Status: Merged
Approved by: Nick Dedekind
Approved revision: no longer in the source branch.
Merged at revision: 532
Proposed branch: lp:~saviq/unity/phablet.protect-local-build-revisions
Merge into: lp:unity/phablet
Diff against target: 78 lines (+21/-0)
1 file modified
build_unity (+21/-0)
To merge this branch: bzr merge lp:~saviq/unity/phablet.protect-local-build-revisions
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Nick Dedekind (community) Approve
Review via email: mp+156793@code.launchpad.net

Commit message

only use revisions known to be working in build_unity script

Description of the change

Due to HUD changing build system and then bumping API version, we've had breakage of the build scripts.

Let's protect ourselves by keeping an explicit revision number that we know is working.

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

LGTM.
tested with full rebuild.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build_unity'
2--- build_unity 2013-04-02 09:19:49 +0000
3+++ build_unity 2013-04-03 10:13:23 +0000
4@@ -9,6 +9,13 @@
5 NUM_JOBS=$(( `grep -c ^processor /proc/cpuinfo` + 1 ))
6 LENSES="applications mockmusic mockvideos"
7
8+# verified working revisions
9+NUX_REV=763
10+LIBUNITY_REV=214
11+UNITY_REV=3257
12+PEOPLE_LENS_REV=73
13+HUD_REV=365
14+
15 usage() {
16 echo "usage: build_unity [OPTIONS]\n"
17 echo "Script to build Unity on Ubuntu 12.10.\n"
18@@ -98,9 +105,11 @@
19 compile_nux() {
20 if [ -d $TARGET_DIR/nux ]; then
21 echo "Configuring Nux.."
22+
23 if $CLEAN; then bzr clean-tree -d $TARGET_DIR/nux --quiet --unknown --ignored --force; fi
24
25 cd $TARGET_DIR/nux
26+ bzr revert --quiet -r $NUX_REV || exit 7
27
28 ./autogen.sh --prefix $BUILD_DIR --disable-debug --disable-documentation
29
30@@ -111,9 +120,11 @@
31
32 compile_libunity() {
33 echo "Configuring libunity.."
34+
35 if $CLEAN; then bzr clean-tree -d $TARGET_DIR/libunity --quiet --unknown --ignored --force; fi
36
37 cd $TARGET_DIR/libunity
38+ bzr revert --quiet -r $LIBUNITY_REV || exit 8
39
40 ./autogen.sh --prefix $BUILD_DIR --disable-debug
41
42@@ -124,8 +135,12 @@
43
44 compile_unity_core() {
45 echo "Configuring Unity.."
46+
47 if $CLEAN; then bzr clean-tree -d $TARGET_DIR/unity --quiet --unknown --ignored --force; fi
48
49+ cd $TARGET_DIR/unity
50+ bzr revert --quiet -r $UNITY_REV || exit 9
51+
52 mkdir $TARGET_DIR/unity/build
53 cd $TARGET_DIR/unity/build
54
55@@ -140,9 +155,11 @@
56
57 compile_people_lens() {
58 echo "Configuring people lens.."
59+
60 if $CLEAN; then bzr clean-tree -d $TARGET_DIR/people_lens --quiet --unknown --ignored --force; fi
61
62 cd $TARGET_DIR/people_lens
63+ bzr revert --quiet -r $PEOPLE_LENS_REV || exit 10
64
65 PKG_CONFIG_PATH=$BUILD_DIR/lib/pkgconfig:$PKG_CONFIG_PATH ./autogen.sh --prefix $BUILD_DIR --enable-localinstall
66
67@@ -153,8 +170,12 @@
68
69 compile_hud() {
70 echo "Configuring hud.."
71+
72 if $CLEAN; then bzr clean-tree -d $TARGET_DIR/hud --quiet --unknown --ignored --force; fi
73
74+ cd $TARGET_DIR/hud
75+ bzr revert -r $HUD_REV || exit 11
76+
77 mkdir $TARGET_DIR/hud/build
78 cd $TARGET_DIR/hud/build
79

Subscribers

People subscribed via source and target branches