Merge lp:~saviq/unity-scopes-api/fix-cross-build into lp:unity-scopes-api/devel

Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 323
Merged at revision: 335
Proposed branch: lp:~saviq/unity-scopes-api/fix-cross-build
Merge into: lp:unity-scopes-api/devel
Diff against target: 41 lines (+3/-4)
2 files modified
CMakeLists.txt (+1/-2)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~saviq/unity-scopes-api/fix-cross-build
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michal Hruby (community) Approve
Review via email: mp+218768@code.launchpad.net

Commit message

Fix cross-building and clean CMakeLists of unused apparmor references.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

> The following packages have unmet dependencies:
> pbuilder-satisfydepends-dummy : Depends: apparmor:native which is a virtual package.
                                 Depends: python3:native which is a virtual package.
> Unable to resolve dependencies! Giving up...

I'm out of my depth here. Any suggestions for fixing this?

Revision history for this message
Michał Sawicz (saviq) wrote :

Yeah, sorry, should have written before - we need to contact the CI folk to check out why :native isn't supported. It might be old pbuilder or so.

I'll keep you posted.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-05-02 13:26:56 +0000
3+++ CMakeLists.txt 2014-05-08 09:56:13 +0000
4@@ -100,7 +100,7 @@
5 endif()
6 set(CAPNPC_FLAGS "" CACHE STRING "Extra flags for capnpc.")
7
8-set(OTHER_INCLUDE_DIRS ${OTHER_INCLUDE_DIRS} ${UNITY_API_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS} ${JSONCPP_INCLUDE_DIRS} ${PROCESS_CPP_INCLUDE_DIRS} ${APPARMOR_INCLUDE_DIRS})
9+set(OTHER_INCLUDE_DIRS ${OTHER_INCLUDE_DIRS} ${UNITY_API_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS} ${JSONCPP_INCLUDE_DIRS} ${PROCESS_CPP_INCLUDE_DIRS})
10 set(OTHER_LIBS ${UNITY_API_LDFLAGS} ${OTHER_LIBS})
11
12 # Standard install paths
13@@ -218,7 +218,6 @@
14 ${Boost_LIBRARIES}
15 ${JSONCPP_LDFLAGS}
16 ${PROCESS_CPP_LDFLAGS}
17- ${APPARMOR_LDFLAGS}
18 ${ZMQPPLIB}
19 ${ZMQLIB}
20 ${CAPNPLIB}
21
22=== modified file 'debian/control'
23--- debian/control 2014-04-28 17:05:32 +0000
24+++ debian/control 2014-05-08 09:56:13 +0000
25@@ -2,14 +2,14 @@
26 Priority: optional
27 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
28 Build-Depends: debhelper (>= 9),
29- apparmor,
30+ apparmor:native,
31 click-dev (>= 0.2.2),
32 cmake,
33 doxygen,
34 google-mock,
35 graphviz,
36 pkg-config,
37- python3,
38+ python3:native,
39 capnproto,
40 libprocess-cpp-dev (>= 1.0.0),
41 libunity-api-dev (>= 7.80.7~),

Subscribers

People subscribed via source and target branches

to all changes: