Merge lp:~saviq/unity-2d/test_launcher-menu-focus into lp:unity-2d

[Michał Sawicz]

[tests] add launcher contextual menu tests

[Albert Astals Cid (aacid)]

It's a bit confusing when you say
  "Check that there's only one action"
and then do
  verify_equal( 2, 0, 'There was an unexpected number of actions in the menu' ) {
    actions.count
  }
The same for the others you say very there's 2 and check against >= 4

[Albert Astals Cid (aacid)]

Also maybe for the
  verify_equal( "true", 0, 'Launcher item didn\'t regain focus' ) {
it'd make sense to have TIMEOUT

[Michał Sawicz (saviq)]

> It's a bit confusing when you say
> "Check that there's only one action"
> and then do
> verify_equal( 2, 0, 'There was an unexpected number of actions in the menu'
> ) {
> actions.count
> }
> The same for the others you say very there's 2 and check against >= 4

Problem is that's actually what we have - check for yourself with tdriver - we have ~2*action_count of QActions. I could maybe check only for those that are active. Let me investigate.

[Albert Astals Cid (aacid)]

Well, the separators are counted as actions and also the titles, i'm not saying the test code is wrong, just that the text is a bit confusing, maybe you could add "Check that there's two action, quit and separator" or something like that

[lp:~saviq/unity-2d/test_launcher-menu-focus]

880. By Michał Sawicz on 2012-01-31

[tests] modify test description to note the "ghost" QActions in the contextual menu

[Michał Sawicz (saviq)]

Comments fixed.

[Michał Sawicz (saviq)]

Wait for it, I'll have another test here.

review: Abstain

[lp:~saviq/unity-2d/test_launcher-menu-focus]

881. By Michał Sawicz on 2012-01-31

[tests] add test to verify launcher menu -> dash focus change

Plus indentation fixes.

882. By Michał Sawicz on 2012-02-02

[test] also kill unity-2d-places for menu tests

[Michał Sawicz (saviq)]

Ready for review.

[Gerry Boland (gerboland)]

Hey I never noticed this in the queue.

Can you update this please to use "shell"? If you don't have time, just say & someone can take it.

[lp:~saviq/unity-2d/test_launcher-menu-focus]

883. By Michał Sawicz on 2012-02-27

Merge trunk

884. By Michał Sawicz on 2012-02-27

[tests/launcher] adapt for current trunk

[Michał Sawicz (saviq)]

Dnia 2012-02-27, pon o godzinie 14:49 +0000, Gerry Boland pisze:
> Can you update this please to use "shell"? If you don't have time,
> just say & someone can take it.

Updated.
--
Michał Sawicz <email address hidden>
Canonical Services Ltd.

[Gerry Boland (gerboland)]

You are using verify_* statements with zero timeout frequently. Please replace the 0 with TIMEOUT, to add timing forgiveness in case software running slowly. Helps reduce false negatives

Also, please have the mouse cursor position reset to a position away from the launcher after each test.

review: Needs Fixing

[Michał Sawicz (saviq)]

Updated.

[lp:~saviq/unity-2d/test_launcher-menu-focus]

885. By Michał Sawicz on 2012-03-06

[tests] fix timeouts and some cleanup in launcher/menu_tests.rb

[Albert Astals Cid (aacid)]

Looks, good to me tests, pass and seems Gerry concerns were fixed too :-)

review: Approve

=== added file 'tests/launcher/menu_tests.rb'
--- tests/launcher/menu_tests.rb	1970-01-01 00:00:00 +0000
+++ tests/launcher/menu_tests.rb	2012-03-06 10:43:18 +0000
@@ -0,0 +1,274 @@
+#!/usr/bin/env ruby1.8
+=begin
+/*
+ * This file is part of unity-2d
+ *
+ * Copyright 2012 Canonical Ltd.
+ *
+ * Authors:
+ * - Michał Sawicz <[e-mail]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+=end
+
+require '../run-tests.rb' unless $INIT_COMPLETED
+require 'xdo/xwindow'
+require 'xdo/keyboard'
+require 'xdo/mouse'
+require 'tmpwindow'
+
+############################# Test Suite #############################
+context "Launcher Contextual Menu Tests" do
+  # Run once at the beginning of this test suite
+  startup do
+    $SUT.execute_shell_command 'killall unity-2d-shell'
+    $SUT.execute_shell_command 'killall unity-2d-shell'
+
+    # Minimize all windows
+    XDo::XWindow.toggle_minimize_all
+  end
+
+  # Run once at the end of this test suite
+  shutdown do
+  end
+
+  # Run before each test case begins
+  setup do
+    # Ensure mouse out of the way
+    XDo::Mouse.move(200,200,10,true)
+
+    # Execute the application
+    @app = $SUT.run( :name => UNITY_2D_SHELL,
+                     :arguments => "-testability",
+                     :sleeptime => 2)
+    # Make certain application is ready for testing
+    verify{ @app.Launcher() }
+  end
+
+  # Run after each test case completes
+  teardown do
+    #@app.close
+    #@app.close
+    #Need to kill Shell as it does not shutdown when politely asked
+    $SUT.execute_shell_command 'pkill -nf unity-2d-shell'
+  end
+
+  #####################################################################################
+  # Test cases
+
+  # Test case objectives:
+  #   * Check that the hint is displayed on mouse hover
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Hover the cursor over the first application entry
+  #   * Check that the hint is displayed
+  #   * Check that there are two QActions (there is a "ghost" QAction there)
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Display launcher item hint" do
+    tiles = ""
+    verify( TIMEOUT, 'Could not find any application tile' ) {
+      tiles = @app.LauncherList( :name => 'main' ).children( { :desktopFile => /^.*.desktop$/ } )
+    }
+    tile = tiles[0]
+    tile.move_mouse()
+    verify(TIMEOUT, 'The launcher item hint is not visible' ) {
+      @app.LauncherContextualMenu()
+    }
+    actions = ""
+    verify( TIMEOUT, 'Could not find any actions in the menu' ) {
+      actions = @app.LauncherContextualMenu().children( { :type => "QAction" } )
+    }
+    verify_equal( 2, TIMEOUT, 'There was an unexpected number of actions in the menu' ) {
+      actions.count
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the menu is displayed on right click
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Right click the first application entry
+  #   * Check that the menu is displayed
+  #   * Check that there are at least four QActions (two actions and separator, plus a "ghost" one)
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Display launcher menu after right click" do
+    tiles = ""
+    verify( TIMEOUT, 'Could not find any application tile' ) {
+      tiles = @app.LauncherList( :name => 'main' ).children( { :desktopFile => /^.*.desktop$/ } )
+    }
+    tile = tiles[0]
+    tile.move_mouse()
+    tile.tap(1, :Right)
+    verify(TIMEOUT, 'The launcher menu is not visible' ) {
+      @app.LauncherContextualMenu()
+    }
+    actions = ""
+    verify( TIMEOUT, 'Could not find any actions in the menu' ) {
+      actions = @app.LauncherContextualMenu().children( { :type => "QAction" } )
+    }
+    verify_true( TIMEOUT, 'There was not enough actions in the menu' ) {
+      actions.count >= 4
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the menu is displayed on right key from item
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go down and right
+  #   * Check that the menu is displayed
+  #   * Check that there are at least four QActions (two actions and separator, plus a "ghost" one)
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Display launcher menu with keyboard navigation" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.down
+    XDo::Keyboard.right
+    verify(TIMEOUT, 'The launcher menu is not visible' ) {
+      @app.LauncherContextualMenu()
+    }
+    actions = ""
+    verify( TIMEOUT, 'Could not find any actions in the menu' ) {
+      actions = @app.LauncherContextualMenu().children( { :type => "QAction" } )
+    }
+    verify_true( TIMEOUT, 'There was not enough actions in the menu' ) {
+      actions.count >= 4
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the menu is being closed on Esc
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go down and right, press Esc
+  #   * Check that the menu is no longer there
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Close launcher menu when pressing Esc" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.down
+    XDo::Keyboard.right
+    XDo::Keyboard.escape
+    verify_not(TIMEOUT, 'The launcher menu is not visible' ) {
+      @app.LauncherContextualMenu()
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the menu is being closed on left key
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go down and right, then left
+  #   * Check that the menu is no longer there
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Close launcher menu when navigating back to the launcher" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.down
+    XDo::Keyboard.right
+    XDo::Keyboard.left
+    verify_not(TIMEOUT, 'The launcher menu is not visible' ) {
+      @app.LauncherContextualMenu()
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the focus goes back to the launcher item when menu was dismissed with Esc
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go down and right, press Esc
+  #   * Check that the launcher item has focus
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Verify launcher tile gets focus after dismissing the menu with Esc" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.down
+    XDo::Keyboard.right
+    XDo::Keyboard.escape
+    tiles = ""
+    verify( TIMEOUT, 'Could not find any application tile' ) {
+      tiles = @app.LauncherList( :name => 'main' ).children( { :desktopFile => /^.*.desktop$/ } )
+    }
+    tile = tiles[0]
+    verify_equal( "true", TIMEOUT, 'Launcher item didn\'t regain focus' ) {
+      tile['activeFocus']
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the focus goes back to the launcher item when menu was dismissed with keyboard navigation
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go down and right, press Esc
+  #   * Check that the launcher item has focus
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Verify launcher tile gets focus after dismissing the menu with keyboard navigation" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.down
+    XDo::Keyboard.right
+    XDo::Keyboard.left
+    tiles = ""
+    verify( TIMEOUT, 'Could not find any application tile' ) {
+      tiles = @app.LauncherList( :name => 'main' ).children( { :desktopFile => /^.*.desktop$/ } )
+    }
+    tile = tiles[0]
+    verify_equal( "true", TIMEOUT, 'Launcher item didn\'t regain focus' ) {
+      tile['activeFocus']
+    }
+  end
+
+  # Test case objectives:
+  #   * Check that the focus goes from launcher menu to dash
+  # Pre-conditions
+  #   * Desktop with no running applications
+  # Test steps
+  #   * Focus the launcher, go right, press Super
+  #   * Check that the dash search entry has focus
+  # Post-conditions
+  #   * None
+  # References
+  #   * None
+  test "Verify dash search entry gets focus after dismissing the menu with Super" do
+    XDo::Keyboard.alt_F1
+    XDo::Keyboard.right
+    XDo::Keyboard.super
+    verify_equal( "true", TIMEOUT, 'Dash search entry doesn\'t have focus' ) {
+      @app.SearchEntry()['activeFocus']
+    }
+  end
+end