Merge lp:~saviq/ubuntu-ui-toolkit/suru-switch into lp:ubuntu-ui-toolkit
- suru-switch
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Tim Peeters |
Approved revision: | 985 |
Merged at revision: | 1038 |
Proposed branch: | lp:~saviq/ubuntu-ui-toolkit/suru-switch |
Merge into: | lp:ubuntu-ui-toolkit |
Prerequisite: | lp:~saviq/ubuntu-ui-toolkit/fix-pep8 |
Diff against target: |
145 lines (+17/-10) 10 files modified
debian/changelog (+6/-0) debian/control (+1/-0) examples/ubuntu-ui-toolkit-gallery/Icons.qml (+1/-1) modules/Ubuntu/Components/Action.qml (+2/-2) modules/Ubuntu/Components/ActionItem.qml (+2/-2) modules/Ubuntu/Components/Icon.qml (+1/-1) modules/Ubuntu/Components/ListItems/Base.qml (+1/-1) modules/Ubuntu/Components/ListItems/Standard.qml (+1/-1) modules/Ubuntu/Components/ListItems/ValueSelector.qml (+1/-1) modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+1/-1) |
To merge this branch: | bzr merge lp:~saviq/ubuntu-ui-toolkit/suru-switch |
Related bugs: | |
Related blueprints: |
Switching to the suru icon theme
(Undefined)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Tim Peeters | Approve | ||
Sebastien Bacher | Pending | ||
Review via email: mp+225136@code.launchpad.net |
This proposal supersedes a proposal from 2014-03-17.
Commit message
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
https:/
https:/
* Is ( your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes.
* Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Not yet, waiting for packages from silo.
* Did you successfully run all tests found in your component's Test Plan (https:/
Not yet, waiting for packages from silo.
* If you changed the UI, was the change specified/approved by design?
Yes, this requirement comes from design.
If you changed the packaging (debian), did you subscribe a core-dev to this MP?
Yes.
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal | # |
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal | # |
PASSED: Continuous integration, rev:978
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
code looks fine, but we need to wait for the suru icons to land in an image and run ci@home.
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
The documentation of various components with an iconName property states that we use the ubuntu-mobile theme. Please update these as well:
tim@ideapad:
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
./modules/
Cris Dywan (kalikiana) wrote : Posted in a previous version of this proposal | # |
ci@home http://
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal | # |
On 20.03.2014 20:00, Tim Peeters wrote:
> The documentation of various components with an iconName property states that we use the ubuntu-mobile theme. Please update these as well:
That's pretty broken, IMO, it should just say "from the icon theme", and
in just one place mention the current default. But that might as well be
done when you allow overriding the theme.
Updated.
Cris Dywan (kalikiana) wrote : Posted in a previous version of this proposal | # |
This may be due to the theme change:
20:37:28.313 ERROR test_notificati
20:37:29.743 ERROR testresult:45 - ERROR: unity8.
20:37:29.744 ERROR testresult:45 - traceback-2: {{{
Traceback (most recent call last):
File "/usr/lib/
obj.
File "/usr/lib/
move_
File "/usr/lib/
Mouse.
File "/usr/lib/
}}}
20:37:29.746 ERROR testresult:45 - traceback: {{{
Traceback (most recent call last):
File "/home/
self.
File "/home/
self.
File "/usr/lib/
raise mismatch_error
MismatchError: After 10.0 seconds test on Notification.
}}}
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal | # |
On 20.03.2014 22:22, Christian Dywan wrote:
> This may be due to the theme change:
> MismatchError: After 10.0 seconds test on Notification.
What image are the tests ran on? We have this issue fixed in unity8
version 7.84+14.
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal | # |
PASSED: Continuous integration, rev:979
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
I am not getting the unity8 failures. I ran tests yesterday for a different MR with image 249, and unity8 AP tests passed. Now I tested with http://
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
did you do manual testing on the device?
I just noticed that the icons in the status bar became slightly bigger, and there is no spacing inbetween them - looks ugly.
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
Tested music-app, all OK: http://
Tested system-settings: http://
11:45:42.878 ERROR testresult:46 - ERROR: ubuntu_
2nd try system-settings: http://
A lot of tests fail here, including:
12:13:53.225 ERROR testresult:46 - ERROR: ubuntu_
12:14:58.567 ERROR testresult:46 - ERROR: ubuntu_
12:15:14.834 ERROR testresult:46 - ERROR: ubuntu_
12:15:49.085 ERROR testresult:46 - ERROR: ubuntu_
12:16:05.161 ERROR testresult:46 - ERROR: ubuntu_
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
after rebooting, ubuntu_
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal | # |
So, can we have top-ACK for this?
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
Another CI@home run: http://
- Lots of failures in UITK
- music_app, clock_app, calculator, file manager, weather: OK
- dialer, messaging FAILURES
- mediaplayer, online accounts OK
- system settings FAILURES
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal | # |
PASSED: Continuous integration, rev:981
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
Please update the icon path also in our uitk-gallery, after this MR lands: https:/
And please re-submit the MR to merge to lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal | # |
Merged trunk, updated the remaining ubuntu-mobile references.
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal | # |
This is now available in silo 004.
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal | # |
FAILED: Continuous integration, rev:983
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal | # |
Code looks good
Tim Peeters (tpeeters) wrote : | # |
good, if CI likes it also
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:983
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
Michał Sawicz (saviq) wrote : | # |
Ugh, forgot to push the pep8 merge.
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:985
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Preview Diff
1 | === modified file 'debian/changelog' |
2 | --- debian/changelog 2014-06-19 06:55:24 +0000 |
3 | +++ debian/changelog 2014-07-01 15:27:51 +0000 |
4 | @@ -1,3 +1,9 @@ |
5 | +ubuntu-ui-toolkit (0.1.48-0ubuntu1) UNRELEASED; urgency=medium |
6 | + |
7 | + * Bump version to indicate requirement for new theme icons. |
8 | + |
9 | + -- Michał Sawicz <michal.sawicz@canonical.com> Tue, 25 Mar 2014 16:11:47 +0100 |
10 | + |
11 | ubuntu-ui-toolkit (0.1.47+14.10.20140619-0ubuntu1) utopic; urgency=low |
12 | |
13 | [ Ubuntu daily release ] |
14 | |
15 | === modified file 'debian/control' |
16 | --- debian/control 2014-05-25 13:09:20 +0000 |
17 | +++ debian/control 2014-07-01 15:27:51 +0000 |
18 | @@ -56,6 +56,7 @@ |
19 | qtdeclarative5-window-plugin, |
20 | qtdeclarative5-qtfeedback-plugin, |
21 | qtdeclarative5-unity-action-plugin (>= 1.1.0), |
22 | + suru-icon-theme, |
23 | ttf-ubuntu-font-family, |
24 | ubuntu-ui-toolkit-theme, |
25 | ${misc:Depends}, |
26 | |
27 | === modified file 'examples/ubuntu-ui-toolkit-gallery/Icons.qml' |
28 | --- examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-04-28 13:19:08 +0000 |
29 | +++ examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-07-01 15:27:51 +0000 |
30 | @@ -89,7 +89,7 @@ |
31 | |
32 | Repeater { |
33 | model: FolderListModel { |
34 | - folder: "/usr/share/icons/ubuntu-mobile/actions/scalable" |
35 | + folder: "/usr/share/icons/suru/actions/scalable" |
36 | showDirs: false |
37 | showOnlyReadable : true |
38 | sortField: FolderListModel.Name |
39 | |
40 | === modified file 'modules/Ubuntu/Components/Action.qml' |
41 | --- modules/Ubuntu/Components/Action.qml 2014-05-10 20:23:26 +0000 |
42 | +++ modules/Ubuntu/Components/Action.qml 2014-07-01 15:27:51 +0000 |
43 | @@ -50,7 +50,7 @@ |
44 | The icon associated with the action. |
45 | \qmlproperty string iconName |
46 | |
47 | - This is the name of the icon in the ubuntu-mobile theme. |
48 | + This is the name of the icon in the suru theme. |
49 | If both iconSource and iconName are defined, iconName will be ignored. |
50 | |
51 | Example: |
52 | @@ -63,7 +63,7 @@ |
53 | \note The complete list of icons available in Ubuntu is not published yet. |
54 | For now please refer to the folder where the icon theme is installed: |
55 | \list |
56 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
57 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
58 | \endlist |
59 | */ |
60 | property string iconName |
61 | |
62 | === modified file 'modules/Ubuntu/Components/ActionItem.qml' |
63 | --- modules/Ubuntu/Components/ActionItem.qml 2014-04-28 19:24:56 +0000 |
64 | +++ modules/Ubuntu/Components/ActionItem.qml 2014-07-01 15:27:51 +0000 |
65 | @@ -60,13 +60,13 @@ |
66 | property url iconSource: action ? action.iconSource : (iconName ? "image://theme/" + iconName : "") |
67 | |
68 | /*! |
69 | - The icon associated with the actionItem in the ubuntu-mobile icon theme. |
70 | + The icon associated with the actionItem in the suru icon theme. |
71 | Default value: action.iconName. |
72 | |
73 | \note The complete list of icons available in Ubuntu is not published yet. |
74 | For now please refer to the folders where the icon themes are installed: |
75 | \list |
76 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
77 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
78 | \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark |
79 | \endlist |
80 | These 2 separate icon themes will be merged soon. |
81 | |
82 | === modified file 'modules/Ubuntu/Components/Icon.qml' |
83 | --- modules/Ubuntu/Components/Icon.qml 2014-04-23 08:50:20 +0000 |
84 | +++ modules/Ubuntu/Components/Icon.qml 2014-07-01 15:27:51 +0000 |
85 | @@ -62,7 +62,7 @@ |
86 | \note The complete list of icons available in Ubuntu is not published yet. |
87 | For now please refer to the folders where the icon themes are installed: |
88 | \list |
89 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
90 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
91 | \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark |
92 | \endlist |
93 | These 2 separate icon themes will be merged soon. |
94 | |
95 | === modified file 'modules/Ubuntu/Components/ListItems/Base.qml' |
96 | --- modules/Ubuntu/Components/ListItems/Base.qml 2014-05-27 12:41:49 +0000 |
97 | +++ modules/Ubuntu/Components/ListItems/Base.qml 2014-07-01 15:27:51 +0000 |
98 | @@ -60,7 +60,7 @@ |
99 | \note The complete list of icons available in Ubuntu is not published yet. |
100 | For now please refer to the folders where the icon themes are installed: |
101 | \list |
102 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
103 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
104 | \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark |
105 | \endlist |
106 | These 2 separate icon themes will be merged soon. |
107 | |
108 | === modified file 'modules/Ubuntu/Components/ListItems/Standard.qml' |
109 | --- modules/Ubuntu/Components/ListItems/Standard.qml 2014-04-28 19:24:56 +0000 |
110 | +++ modules/Ubuntu/Components/ListItems/Standard.qml 2014-07-01 15:27:51 +0000 |
111 | @@ -92,7 +92,7 @@ |
112 | \note The complete list of icons available in Ubuntu is not published yet. |
113 | For now please refer to the folders where the icon themes are installed: |
114 | \list |
115 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
116 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
117 | \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark |
118 | \endlist |
119 | These 2 separate icon themes will be merged soon. |
120 | |
121 | === modified file 'modules/Ubuntu/Components/ListItems/ValueSelector.qml' |
122 | --- modules/Ubuntu/Components/ListItems/ValueSelector.qml 2014-04-28 19:47:05 +0000 |
123 | +++ modules/Ubuntu/Components/ListItems/ValueSelector.qml 2014-07-01 15:27:51 +0000 |
124 | @@ -96,7 +96,7 @@ |
125 | \note The complete list of icons available in Ubuntu is not published yet. |
126 | For now please refer to the folders where the icon themes are installed: |
127 | \list |
128 | - \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile |
129 | + \li Ubuntu Touch: \l file:/usr/share/icons/suru |
130 | \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark |
131 | \endlist |
132 | These 2 separate icon themes will be merged soon. |
133 | |
134 | === modified file 'modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp' |
135 | --- modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp 2014-02-24 18:20:43 +0000 |
136 | +++ modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp 2014-07-01 15:27:51 +0000 |
137 | @@ -23,7 +23,7 @@ |
138 | UnityThemeIconProvider::UnityThemeIconProvider(): |
139 | QQuickImageProvider(QQuickImageProvider::Pixmap) |
140 | { |
141 | - QIcon::setThemeName("ubuntu-mobile"); |
142 | + QIcon::setThemeName("suru"); |
143 | } |
144 | |
145 | QPixmap UnityThemeIconProvider::requestPixmap(const QString &id, QSize *realSize, const QSize &requestedSize) |
+1