Merge lp:~saviq/ubuntu-ui-toolkit/suru-switch into lp:ubuntu-ui-toolkit

Proposed by Michał Sawicz
Status: Merged
Approved by: Tim Peeters
Approved revision: 985
Merged at revision: 1038
Proposed branch: lp:~saviq/ubuntu-ui-toolkit/suru-switch
Merge into: lp:ubuntu-ui-toolkit
Prerequisite: lp:~saviq/ubuntu-ui-toolkit/fix-pep8
Diff against target: 145 lines (+17/-10)
10 files modified
debian/changelog (+6/-0)
debian/control (+1/-0)
examples/ubuntu-ui-toolkit-gallery/Icons.qml (+1/-1)
modules/Ubuntu/Components/Action.qml (+2/-2)
modules/Ubuntu/Components/ActionItem.qml (+2/-2)
modules/Ubuntu/Components/Icon.qml (+1/-1)
modules/Ubuntu/Components/ListItems/Base.qml (+1/-1)
modules/Ubuntu/Components/ListItems/Standard.qml (+1/-1)
modules/Ubuntu/Components/ListItems/ValueSelector.qml (+1/-1)
modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp (+1/-1)
To merge this branch: bzr merge lp:~saviq/ubuntu-ui-toolkit/suru-switch
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Sebastien Bacher Pending
Review via email: mp+225136@code.launchpad.net

This proposal supersedes a proposal from 2014-03-17.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~saviq/ubuntu-ui-toolkit/fix-pep8/+merge/225135
https://code.launchpad.net/~unity-team/unity8/suru-switch/+merge/207991

* Is ( your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes.

* Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Not yet, waiting for packages from silo.

* Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ui-toolkit) on device or emulator?
Not yet, waiting for packages from silo.

* If you changed the UI, was the change specified/approved by design?
Yes, this requirement comes from design.

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
Yes.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

code looks fine, but we need to wait for the suru icons to land in an image and run ci@home.

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

The documentation of various components with an iconName property states that we use the ubuntu-mobile theme. Please update these as well:

tim@ideapad:~/dev/ubuntu-ui-toolkit/trunk$ grep ubuntu-mobile `find . -name "*.qml"`
./modules/Ubuntu/Components/ActionItem.qml: The icon associated with the actionItem in the ubuntu-mobile icon theme.
./modules/Ubuntu/Components/Action.qml: This is the name of the icon in the ubuntu-mobile theme.
./modules/Ubuntu/Components/Action.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/OptionSelectorDelegate.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/Standard.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/Standard.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/Base.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/Base.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/ValueSelector.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/ListItems/ValueSelector.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
./modules/Ubuntu/Components/Icon.qml: \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile

review: Needs Fixing
Revision history for this message
Cris Dywan (kalikiana) wrote : Posted in a previous version of this proposal

ci@home http://paste.ubuntu.com/7127247/ image 249 - plenty failures though I doubt they're all icon-related.

Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

On 20.03.2014 20:00, Tim Peeters wrote:
> The documentation of various components with an iconName property states that we use the ubuntu-mobile theme. Please update these as well:

That's pretty broken, IMO, it should just say "from the icon theme", and
in just one place mention the current default. But that might as well be
done when you allow overriding the theme.

Updated.

Revision history for this message
Cris Dywan (kalikiana) wrote : Posted in a previous version of this proposal

This may be due to the theme change:

20:37:28.313 ERROR test_notifications:291 - Notification process wasn't killed, killing now.
20:37:29.743 ERROR testresult:45 - ERROR: unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_sd_incoming_call(Native Device)
20:37:29.744 ERROR testresult:45 - traceback-2: {{{
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/autopilot/utilities.py", line 335, in action_on_test_end
    obj.on_test_end(test_instance)
  File "/usr/lib/python2.7/dist-packages/autopilot/input/_X11.py", line 493, in on_test_end
    move_mouse_to_screen(0)
  File "/usr/lib/python2.7/dist-packages/autopilot/display/__init__.py", line 59, in move_mouse_to_screen
    Mouse.create().move(x, y, False)
  File "/usr/lib/python2.7/dist-packages/autopilot/input/__init__.py", line 293, in create
}}}
20:37:29.746 ERROR testresult:45 - traceback: {{{
Traceback (most recent call last):
  File "/home/phablet/autopilot/unity8/shell/tests/test_notifications.py", line 199, in test_sd_incoming_call
    self._assert_notification(notification, None, None, True, True, 1.0)
  File "/home/phablet/autopilot/unity8/shell/tests/test_notifications.py", line 96, in _assert_notification
    self.assertThat(notification.iconSource, Eventually(NotEquals("")))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: After 10.0 seconds test on Notification.iconSource failed: u'' == dbus.String(u'', variant_level=1)
}}}

Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

On 20.03.2014 22:22, Christian Dywan wrote:
> This may be due to the theme change:

> MismatchError: After 10.0 seconds test on Notification.iconSource failed: u'' == dbus.String(u'', variant_level=1)

What image are the tests ran on? We have this issue fixed in unity8
version 7.84+14.04.20140317.2-0ubuntu1.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

I am not getting the unity8 failures. I ran tests yesterday for a different MR with image 249, and unity8 AP tests passed. Now I tested with http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/874/artifact/work/output/*zip*/output.zip and image 250, and all unity8 tests pass: http://paste.ubuntu.com/7130114/

Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

did you do manual testing on the device?

I just noticed that the icons in the status bar became slightly bigger, and there is no spacing inbetween them - looks ugly.

review: Needs Fixing
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

Tested music-app, all OK: http://paste.ubuntu.com/7130220/

Tested system-settings: http://paste.ubuntu.com/7130184/ one failure:
11:45:42.878 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_about.StorageTestCase.test_storage_page(with touch)

2nd try system-settings: http://paste.ubuntu.com/7130289/
A lot of tests fail here, including:
12:13:53.225 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_about.AboutTestCase.test_imei(with touch)
12:14:58.567 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_cellular.CellularTestCase.test_current_network(with touch)
12:15:14.834 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_about.StorageTestCase.test_disk(with touch)
12:15:49.085 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_plugins.SystemSettingsTestCases.test_background_plugin(with touch)
12:16:05.161 ERROR testresult:46 - ERROR: ubuntu_system_settings.tests.test_plugins.SystemSettingsTestCases.test_cellular_plugin(with touch)

Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

after rebooting, ubuntu_system_settings CI@home all OK: http://paste.ubuntu.com/7131156/

Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

So, can we have top-ACK for this?

Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

Another CI@home run: http://paste.ubuntu.com/7151431/ (image 259)
- Lots of failures in UITK
- music_app, clock_app, calculator, file manager, weather: OK
- dialer, messaging FAILURES
- mediaplayer, online accounts OK
- system settings FAILURES

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

Please update the icon path also in our uitk-gallery, after this MR lands: https://code.launchpad.net/~kalikiana/ubuntu-ui-toolkit/demoIcons/+merge/217433

And please re-submit the MR to merge to lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

Merged trunk, updated the remaining ubuntu-mobile references.

Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

This is now available in silo 004.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

Code looks good

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

good, if CI likes it also

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Ugh, forgot to push the pep8 merge.

Revision history for this message
Tim Peeters (tpeeters) wrote :

ok

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-06-19 06:55:24 +0000
3+++ debian/changelog 2014-07-01 15:27:51 +0000
4@@ -1,3 +1,9 @@
5+ubuntu-ui-toolkit (0.1.48-0ubuntu1) UNRELEASED; urgency=medium
6+
7+ * Bump version to indicate requirement for new theme icons.
8+
9+ -- Michał Sawicz <michal.sawicz@canonical.com> Tue, 25 Mar 2014 16:11:47 +0100
10+
11 ubuntu-ui-toolkit (0.1.47+14.10.20140619-0ubuntu1) utopic; urgency=low
12
13 [ Ubuntu daily release ]
14
15=== modified file 'debian/control'
16--- debian/control 2014-05-25 13:09:20 +0000
17+++ debian/control 2014-07-01 15:27:51 +0000
18@@ -56,6 +56,7 @@
19 qtdeclarative5-window-plugin,
20 qtdeclarative5-qtfeedback-plugin,
21 qtdeclarative5-unity-action-plugin (>= 1.1.0),
22+ suru-icon-theme,
23 ttf-ubuntu-font-family,
24 ubuntu-ui-toolkit-theme,
25 ${misc:Depends},
26
27=== modified file 'examples/ubuntu-ui-toolkit-gallery/Icons.qml'
28--- examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-04-28 13:19:08 +0000
29+++ examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-07-01 15:27:51 +0000
30@@ -89,7 +89,7 @@
31
32 Repeater {
33 model: FolderListModel {
34- folder: "/usr/share/icons/ubuntu-mobile/actions/scalable"
35+ folder: "/usr/share/icons/suru/actions/scalable"
36 showDirs: false
37 showOnlyReadable : true
38 sortField: FolderListModel.Name
39
40=== modified file 'modules/Ubuntu/Components/Action.qml'
41--- modules/Ubuntu/Components/Action.qml 2014-05-10 20:23:26 +0000
42+++ modules/Ubuntu/Components/Action.qml 2014-07-01 15:27:51 +0000
43@@ -50,7 +50,7 @@
44 The icon associated with the action.
45 \qmlproperty string iconName
46
47- This is the name of the icon in the ubuntu-mobile theme.
48+ This is the name of the icon in the suru theme.
49 If both iconSource and iconName are defined, iconName will be ignored.
50
51 Example:
52@@ -63,7 +63,7 @@
53 \note The complete list of icons available in Ubuntu is not published yet.
54 For now please refer to the folder where the icon theme is installed:
55 \list
56- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
57+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
58 \endlist
59 */
60 property string iconName
61
62=== modified file 'modules/Ubuntu/Components/ActionItem.qml'
63--- modules/Ubuntu/Components/ActionItem.qml 2014-04-28 19:24:56 +0000
64+++ modules/Ubuntu/Components/ActionItem.qml 2014-07-01 15:27:51 +0000
65@@ -60,13 +60,13 @@
66 property url iconSource: action ? action.iconSource : (iconName ? "image://theme/" + iconName : "")
67
68 /*!
69- The icon associated with the actionItem in the ubuntu-mobile icon theme.
70+ The icon associated with the actionItem in the suru icon theme.
71 Default value: action.iconName.
72
73 \note The complete list of icons available in Ubuntu is not published yet.
74 For now please refer to the folders where the icon themes are installed:
75 \list
76- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
77+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
78 \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark
79 \endlist
80 These 2 separate icon themes will be merged soon.
81
82=== modified file 'modules/Ubuntu/Components/Icon.qml'
83--- modules/Ubuntu/Components/Icon.qml 2014-04-23 08:50:20 +0000
84+++ modules/Ubuntu/Components/Icon.qml 2014-07-01 15:27:51 +0000
85@@ -62,7 +62,7 @@
86 \note The complete list of icons available in Ubuntu is not published yet.
87 For now please refer to the folders where the icon themes are installed:
88 \list
89- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
90+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
91 \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark
92 \endlist
93 These 2 separate icon themes will be merged soon.
94
95=== modified file 'modules/Ubuntu/Components/ListItems/Base.qml'
96--- modules/Ubuntu/Components/ListItems/Base.qml 2014-05-27 12:41:49 +0000
97+++ modules/Ubuntu/Components/ListItems/Base.qml 2014-07-01 15:27:51 +0000
98@@ -60,7 +60,7 @@
99 \note The complete list of icons available in Ubuntu is not published yet.
100 For now please refer to the folders where the icon themes are installed:
101 \list
102- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
103+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
104 \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark
105 \endlist
106 These 2 separate icon themes will be merged soon.
107
108=== modified file 'modules/Ubuntu/Components/ListItems/Standard.qml'
109--- modules/Ubuntu/Components/ListItems/Standard.qml 2014-04-28 19:24:56 +0000
110+++ modules/Ubuntu/Components/ListItems/Standard.qml 2014-07-01 15:27:51 +0000
111@@ -92,7 +92,7 @@
112 \note The complete list of icons available in Ubuntu is not published yet.
113 For now please refer to the folders where the icon themes are installed:
114 \list
115- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
116+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
117 \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark
118 \endlist
119 These 2 separate icon themes will be merged soon.
120
121=== modified file 'modules/Ubuntu/Components/ListItems/ValueSelector.qml'
122--- modules/Ubuntu/Components/ListItems/ValueSelector.qml 2014-04-28 19:47:05 +0000
123+++ modules/Ubuntu/Components/ListItems/ValueSelector.qml 2014-07-01 15:27:51 +0000
124@@ -96,7 +96,7 @@
125 \note The complete list of icons available in Ubuntu is not published yet.
126 For now please refer to the folders where the icon themes are installed:
127 \list
128- \li Ubuntu Touch: \l file:/usr/share/icons/ubuntu-mobile
129+ \li Ubuntu Touch: \l file:/usr/share/icons/suru
130 \li Ubuntu Desktop: \l file:/usr/share/icons/ubuntu-mono-dark
131 \endlist
132 These 2 separate icon themes will be merged soon.
133
134=== modified file 'modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp'
135--- modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp 2014-02-24 18:20:43 +0000
136+++ modules/Ubuntu/Components/plugin/unitythemeiconprovider.cpp 2014-07-01 15:27:51 +0000
137@@ -23,7 +23,7 @@
138 UnityThemeIconProvider::UnityThemeIconProvider():
139 QQuickImageProvider(QQuickImageProvider::Pixmap)
140 {
141- QIcon::setThemeName("ubuntu-mobile");
142+ QIcon::setThemeName("suru");
143 }
144
145 QPixmap UnityThemeIconProvider::requestPixmap(const QString &id, QSize *realSize, const QSize &requestedSize)

Subscribers

People subscribed via source and target branches

to status/vote changes: