Merge lp:~saviq/ubuntu-system-settings/fix-wizard-sim into lp:ubuntu-system-settings

Proposed by Michał Sawicz
Status: Merged
Approved by: Iain Lane
Approved revision: 794
Merged at revision: 797
Proposed branch: lp:~saviq/ubuntu-system-settings/fix-wizard-sim
Merge into: lp:ubuntu-system-settings
Diff against target: 27 lines (+7/-2)
1 file modified
wizard/qml/Pages/10-welcome.qml (+7/-2)
To merge this branch: bzr merge lp:~saviq/ubuntu-system-settings/fix-wizard-sim
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ken VanDine Approve
Sergio Schvezov (community) Needs Information
Review via email: mp+226555@code.launchpad.net

Commit message

Move wizard welcome page to libqofono SIM backend.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:794
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/972/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1907
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1586
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/164
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/164
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/164/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/164
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2161
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3010
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3010/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9741
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1329
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1776
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1776/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/972/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) :
review: Needs Information
Revision history for this message
Ken VanDine (ken-vandine) wrote :

This looks good, tested on mako and worked well. We'll deal with multisim along with the rest of the places using it.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:794
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/982/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1943
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1623
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/174
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/174
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/174/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/174
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2191
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3055
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3055/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9790
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1359
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1826
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1826/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/982/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'wizard/qml/Pages/10-welcome.qml'
2--- wizard/qml/Pages/10-welcome.qml 2014-03-20 15:01:23 +0000
3+++ wizard/qml/Pages/10-welcome.qml 2014-07-11 23:12:22 +0000
4@@ -18,7 +18,7 @@
5 import Ubuntu.Components 0.1
6 import Ubuntu.Components.ListItems 0.1 as ListItem
7 import Ubuntu.SystemSettings.LanguagePlugin 1.0
8-import Ubuntu.SystemSettings.Phone 1.0
9+import MeeGo.QOfono 0.2
10 import "../Components" as LocalComponents
11
12 LocalComponents.Page {
13@@ -29,8 +29,13 @@
14 id: plugin
15 }
16
17- SimManager {
18+ OfonoManager {
19+ id: manager
20+ }
21+
22+ OfonoSimManager {
23 id: simManager
24+ modemPath: manager.modems[0]
25 }
26
27 Item {

Subscribers

People subscribed via source and target branches