Merge ~saviq/repowerd:wants-android into repowerd:master

[Michał Sawicz]

Don't Require lxc-android-config (LP: #1602597)

Requires: means that the service has to be there, but repowerd is
supposed to work on non-android devices, too.

[Daniel van Vugt (vanvugt)]

Yes, but maybe no.

On systems where lxc-android-config.service exists, using 'Wants' will make the system unreliable and unpredictable. repowerd could then start prematurely when lxc-android-config hasn't, which could presumably mess it up.

But I think I'm now describing a design flaw in systemd in general...?

review: Needs Information

[Daniel van Vugt (vanvugt)]

Also the systemd docs do not state that 'Wants' works in the case where the prerequisite doesn't exist at all.

review: Needs Information

[Daniel van Vugt (vanvugt)]

Sounds better now, but needs testing still.

review: Needs Information

[Daniel van Vugt (vanvugt)]

Tested on yakkety. With this change repowerd starts by default with one caveat: systemd thinks it's still starting indefinitely. So we're still missing some setting that tells systemd it's finished starting.

review: Approve

[Daniel van Vugt (vanvugt)]

Whoops.

The process starts but because it apparently never finishes starting, systemd times out and kills it again.

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

I know nothing. Alf is looking at it now.

review: Abstain

[Alexandros Frantzis (afrantzis)]

Looks good

review: Approve

diff --git a/debian/repowerd.service b/debian/repowerd.service
index 59f220f..5187a0d 100644
--- a/debian/repowerd.service
+++ b/debian/repowerd.service
@@ -1,6 +1,6 @@
 [Unit]
 Description=monitor and control system power state
-Requires=lxc-android-config.service
+Wants=lxc-android-config.service
 After=lxc-android-config.service
 
 [Service]