repowerd

Merge ~saviq/repowerd:wants-android into repowerd:master

  1. Git
  2. lp:~saviq/repowerd
  3. wants-android
  4. Merge into master
Proposed by Michał Sawicz
Status: Merged
Approved by: Alexandros Frantzis
Approved revision: 452cc6592a85e1bdcf83aed17290dc1095e05b95
Merged at revision: 452cc6592a85e1bdcf83aed17290dc1095e05b95
Proposed branch: ~saviq/repowerd:wants-android
Merge into: repowerd:master
Diff against target: 12 lines (+1/-1)
1 file modified
debian/repowerd.service (+1/-1)
Reviewer Review Type Date Requested Status
Alexandros Frantzis Approve
Daniel van Vugt (community) Abstain
Review via email: mp+299925@code.launchpad.net

Commit message

Don't Require lxc-android-config (LP: #1602597)

Requires: means that the service has to be there, but repowerd is
supposed to work on non-android devices, too.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes, but maybe no.

On systems where lxc-android-config.service exists, using 'Wants' will make the system unreliable and unpredictable. repowerd could then start prematurely when lxc-android-config hasn't, which could presumably mess it up.

But I think I'm now describing a design flaw in systemd in general...?

review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also the systemd docs do not state that 'Wants' works in the case where the prerequisite doesn't exist at all.

review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sounds better now, but needs testing still.

review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Tested on yakkety. With this change repowerd starts by default with one caveat: systemd thinks it's still starting indefinitely. So we're still missing some setting that tells systemd it's finished starting.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Whoops.

The process starts but because it apparently never finishes starting, systemd times out and kills it again.

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I know nothing. Alf is looking at it now.

review: Abstain
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/repowerd.service b/debian/repowerd.service
2index 59f220f..5187a0d 100644
3--- a/debian/repowerd.service
4+++ b/debian/repowerd.service
5@@ -1,6 +1,6 @@
6 [Unit]
7 Description=monitor and control system power state
8-Requires=lxc-android-config.service
9+Wants=lxc-android-config.service
10 After=lxc-android-config.service
11
12 [Service]

Subscribers

People subscribed via source and target branches