Merge lp:~saviq/qtmir/fix-application-api-deps into lp:qtmir

Proposed by Michał Sawicz
Status: Merged
Approved by: Gerry Boland
Approved revision: 331
Merged at revision: 333
Proposed branch: lp:~saviq/qtmir/fix-application-api-deps
Merge into: lp:qtmir
Diff against target: 45 lines (+5/-3)
3 files modified
CMakeLists.txt (+1/-0)
debian/control (+1/-1)
src/modules/Unity/Application/CMakeLists.txt (+3/-2)
To merge this branch: bzr merge lp:~saviq/qtmir/fix-application-api-deps
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Gerry Boland (community) Approve
Ubuntu Unity PS integration team Pending
Review via email: mp+255839@code.launchpad.net

Commit message

Require an application API version, fix the provided version and use include dir from the .pc file

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Y

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM
 * Did you perform an exploratory manual test run of the code change and any related functionality?
Y
 * Did CI run pass? If not, please explain why.
Y

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2015-03-18 10:12:16 +0000
3+++ CMakeLists.txt 2015-05-05 09:46:22 +0000
4@@ -79,6 +79,7 @@
5 pkg_check_modules(LTTNG lttng-ust)
6 pkg_check_modules(QTDBUSTEST libqtdbustest-1 REQUIRED)
7 pkg_check_modules(QTDBUSMOCK libqtdbusmock-1 REQUIRED)
8+pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=5)
9
10 add_definitions(-DMIR_REQUIRE_DEPRECATED_EVENT_OPT_IN=1)
11
12
13=== modified file 'debian/control'
14--- debian/control 2015-03-04 17:08:47 +0000
15+++ debian/control 2015-05-05 09:46:22 +0000
16@@ -99,7 +99,7 @@
17 Conflicts: libqtmir,
18 libunity-mir1,
19 Provides: unity-application-impl,
20- unity-application-impl-4,
21+ unity-application-impl-5,
22 Description: Qt plugin for Unity specific Mir APIs
23 QtMir provides Qt/QML bindings for Mir features that are exposed through the
24 qtmir-desktop or qtmir-android QPA plugin such as Application management
25
26=== modified file 'src/modules/Unity/Application/CMakeLists.txt'
27--- src/modules/Unity/Application/CMakeLists.txt 2015-01-08 12:37:08 +0000
28+++ src/modules/Unity/Application/CMakeLists.txt 2015-05-05 09:46:22 +0000
29@@ -1,4 +1,5 @@
30 include_directories(
31+ ${APPLICATION_API_INCLUDE_DIRS}
32 ${GLIB_INCLUDE_DIRS}
33 ${GIO_INCLUDE_DIRS}
34 ${GIO_UNIX_INCLUDE_DIRS}
35@@ -42,8 +43,8 @@
36 upstart/applicationcontroller.cpp
37 tracepoints.c
38 # We need to run moc on these headers
39- /usr/include/unity/shell/application/ApplicationInfoInterface.h
40- /usr/include/unity/shell/application/ApplicationManagerInterface.h
41+ ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationInfoInterface.h
42+ ${APPLICATION_API_INCLUDEDIR}/unity/shell/application/ApplicationManagerInterface.h
43 # Feed the automoc monster
44 session_interface.h
45 applicationcontroller.h

Subscribers

People subscribed via source and target branches