Merge ~saviq/mir-kiosk:no-overlay into ~mir-team/mir-kiosk/+git/mir-kiosk-old:master

Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: d2681fa90c9e04a149fda4c4bc7cecff2aeb6aab
Merged at revision: d2681fa90c9e04a149fda4c4bc7cecff2aeb6aab
Proposed branch: ~saviq/mir-kiosk:no-overlay
Merge into: ~mir-team/mir-kiosk/+git/mir-kiosk-old:master
Diff against target: 48 lines (+26/-5)
1 file modified
snap/snapcraft.yaml (+26/-5)
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
Alberto Aguirre (community) Approve
Review via email: mp+324180@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

LGTM. Builds in a clean container with xenial-proposed.

review: Approve
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Worked with in a AMD64 VM ubuntu core image

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

The snap version should probably be changed to "1.3.2" to match the lp:miral/release branch version.

Revision history for this message
Michał Sawicz (saviq) wrote :

> The snap version should probably be changed to "1.3.2" to match the lp:miral/release branch version.
Done

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index abff93d..7fa9032 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -1,5 +1,5 @@
6 name: mir-kiosk
7-version: 1.2.0 #The miral-examples version
8+version: 1.2.3 # The miral release version
9 summary: A minimal Mir based shell for kiosk type applications
10 description: A minimal Mir based shell for kiosk type applications
11 confinement: strict
12@@ -23,11 +23,32 @@ apps:
13
14 parts:
15 miral-examples:
16- plugin: nil
17- stage-packages:
18- - miral-examples
19+ plugin: cmake
20+ source: lp:miral/release
21+ configflags:
22+ - -DCMAKE_INSTALL_PREFIX=/usr
23 build-attributes:
24- - no-system-libraries
25+ - no-system-libraries
26+ build-packages:
27+ - build-essential
28+ - libfreetype6-dev
29+ - libgles2-mesa-dev
30+ - libglib2.0-dev
31+ - libmirserver-dev
32+ - libmirclient-dev
33+ - pkg-config
34+ - python-pil
35+ stage-packages:
36+ - libboost-filesystem1.58.0
37+ - libboost-program-options1.58.0
38+ - libboost-system1.58.0
39+ - libegl1-mesa
40+ - libfreetype6
41+ - libgles2-mesa
42+ - libglib2.0-0
43+ - libnettle6
44+ - libprotobuf-lite9v5
45+ - libxkbcommon0
46 prime:
47 - usr/lib
48 - -usr/lib/*/libmir* #Use the libraries from mir-libs content plug

Subscribers

People subscribed via source and target branches