Merge ~saviq/jenkaas-jobs:early-release into jenkaas-jobs:master

Proposed by Michał Sawicz
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 5a8c47dae582ceac0047ec3c4cd2bd17d7fbaeac
Merged at revision: 5a8c47dae582ceac0047ec3c4cd2bd17d7fbaeac
Proposed branch: ~saviq/jenkaas-jobs:early-release
Merge into: jenkaas-jobs:master
Diff against target: 35 lines (+14/-0)
2 files modified
jenkaas_jobs/yaml/prepare/prepare-2-chroots.sh (+7/-0)
tests/fixtures/prepare/prepare-2-chroots.xml (+7/-0)
Reviewer Review Type Date Requested Status
Olivier Tilloy (community) Approve
Review via email: mp+312910@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

This looks okay to me. Not sure about the "-i" parameter to ln, though.

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/jenkaas_jobs/yaml/prepare/prepare-2-chroots.sh b/jenkaas_jobs/yaml/prepare/prepare-2-chroots.sh
2index 43852f1..0b4f02d 100644
3--- a/jenkaas_jobs/yaml/prepare/prepare-2-chroots.sh
4+++ b/jenkaas_jobs/yaml/prepare/prepare-2-chroots.sh
5@@ -30,6 +30,13 @@ if [ ! -e /etc/schroot/chroot.d/sbuild-${{NAME}} ]; then
6 # remove any stale chroots
7 sudo rm -Rf /var/lib/schroot/chroots/${{NAME}}
8
9+ # link gutsy to the passed release, in case it doesn't know it yet
10+ if [ ! -r /usr/share/debootstrap/scripts/${{release%%+*}} ]; then
11+ pushd /usr/share/debootstrap/scripts
12+ sudo ln -vs gutsy ${{release%%+*}}
13+ popd
14+ fi
15+
16 # build the chroot
17 mk-sbuild --name=${{release}} ${{ARGS}} ${{release%%+*}}
18
19diff --git a/tests/fixtures/prepare/prepare-2-chroots.xml b/tests/fixtures/prepare/prepare-2-chroots.xml
20index 1252ced..5e43922 100644
21--- a/tests/fixtures/prepare/prepare-2-chroots.xml
22+++ b/tests/fixtures/prepare/prepare-2-chroots.xml
23@@ -92,6 +92,13 @@ if [ ! -e /etc/schroot/chroot.d/sbuild-${NAME} ]; then
24 # remove any stale chroots
25 sudo rm -Rf /var/lib/schroot/chroots/${NAME}
26
27+ # link gutsy to the passed release, in case it doesn't know it yet
28+ if [ ! -r /usr/share/debootstrap/scripts/${release%%+*} ]; then
29+ pushd /usr/share/debootstrap/scripts
30+ sudo ln -vs gutsy ${release%%+*}
31+ popd
32+ fi
33+
34 # build the chroot
35 mk-sbuild --name=${release} ${ARGS} ${release%%+*}
36

Subscribers

People subscribed via source and target branches