Code review comment for lp:~saviq/elisa/freeze_plugins

Revision history for this message
Olivier Tilloy (osomon) wrote :

You added an extra parameter to the do_process_plugins function, but you forgot to adapt 7 other places in the code where it is called.

If in my configuration I set "auto_update_plugins" to "False", I will then get a popup upon availability of updates, and clicking "Update All" will fail with the following traceback:

Traceback (most recent call last):
  File "/home/osomon/dev/elisa-branches/moovida/elisa-plugins/elisa/plugins/poblesec/modal_popup.py", line 148, in _clicked_cb
    button.callback()
  File "/home/osomon/dev/elisa-branches/moovida/elisa-plugins/elisa/plugins/poblesec/main.py", line 592, in <lambda>
    message.new_recommended)),
TypeError: do_process_plugins() takes exactly 3 arguments (2 given)

review: Needs Fixing (functional)

« Back to merge proposal