Merge lp:~saviq/address-book-app/new-icon into lp:address-book-app

Proposed by Michał Sawicz
Status: Merged
Approved by: Bill Filler
Approved revision: 216
Merged at revision: 219
Proposed branch: lp:~saviq/address-book-app/new-icon
Merge into: lp:address-book-app
Diff against target: 25 lines (+2/-5)
2 files modified
data/CMakeLists.txt (+1/-4)
data/address-book-app.desktop.in (+1/-1)
To merge this branch: bzr merge lp:~saviq/address-book-app/new-icon
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+224305@code.launchpad.net

Commit message

New icon. Also drop difference between click mode and not, as both support theme-sourced icons.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~saviq/address-book-app/new-icon updated
216. By Michał Sawicz

Fix CMake.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

apprvoed

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2014-06-05 16:35:45 +0000
3+++ data/CMakeLists.txt 2014-06-24 18:09:09 +0000
4@@ -1,7 +1,4 @@
5-if (CLICK_MODE)
6- set(ADDRESSBOOK_APP_ICON "share/icons/hicolor/scalable/apps/contacts-app.svg")
7-else()
8- set(ADDRESSBOOK_APP_ICON "contacts-app")
9+if (NOT CLICK_MODE)
10 set(XSCREENSHOT "X-Screenshot=${ADDRESS_BOOK_APP_FULL_DIR}/artwork/address-book-app-preview.png")
11 endif()
12
13
14=== modified file 'data/address-book-app.desktop.in'
15--- data/address-book-app.desktop.in 2014-01-10 22:09:07 +0000
16+++ data/address-book-app.desktop.in 2014-06-24 18:09:09 +0000
17@@ -7,7 +7,7 @@
18 GenericName=tr("Contacts")
19 Comment=tr("Contacts Address Book")
20 Exec=@DESKTOP_EXEC@ %u
21-Icon=@ADDRESSBOOK_APP_ICON@
22+Icon=address-book-app
23 X-Ubuntu-Touch=true
24 X-Ubuntu-StageHint=SideStage
25 X-Ubuntu-Gettext-Domain=address-book-app

Subscribers

People subscribed via source and target branches