Merge lp:~savilerow-team/savilerow/unity-scope-tourism-shanghai-mockweather-lp1322337 into lp:~savilerow-team/savilerow/unity-scope-tourism-shanghai-mockweather

Proposed by Scott Sweeny
Status: Merged
Merged at revision: 15
Proposed branch: lp:~savilerow-team/savilerow/unity-scope-tourism-shanghai-mockweather-lp1322337
Merge into: lp:~savilerow-team/savilerow/unity-scope-tourism-shanghai-mockweather
Diff against target: 47 lines (+13/-6)
2 files modified
data/tourism-mockweather.json.in (+6/-6)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~savilerow-team/savilerow/unity-scope-tourism-shanghai-mockweather-lp1322337
Reviewer Review Type Date Requested Status
Chris Wayne (community) Approve
Review via email: mp+221964@code.launchpad.net

Description of the change

Two changes:

1. Populate the "link" fields of results with a non-empty string since the API seems to have become more strict lately.

2. Use the SCOPE_INSTALL_DIR CMake variable in the image paths so they are always in sync with where the scope is installed.

Tested by cwayne on his phone.

To post a comment you must log in.
Revision history for this message
Chris Wayne (cwayne) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/tourism-mockweather.json.in'
2--- data/tourism-mockweather.json.in 2014-05-01 04:58:15 +0000
3+++ data/tourism-mockweather.json.in 2014-06-03 21:26:01 +0000
4@@ -2,22 +2,22 @@
5 {
6 "title": "Shanghai, CN Today",
7 "subtitle": "10°C",
8- "link": "",
9- "image": "file:///custom/usr/lib/arm-linux-gnueabihf/unity/scopes/scope-tourism-mockweather/images/overcast.png",
10+ "link": "http://www.weather.com",
11+ "image": "file://@SCOPE_INSTALL_DIR@/images/overcast.png",
12 "description": "Minimum temperature: 9°\nMaximum temperature: 14°\nChance of rain: 10%\n Wind: WSW at 16 km/h\nHumidity: 76%\nUV index: 3"
13 },
14 {
15 "title": "Tomorrow",
16 "subtitle": "14°C",
17- "link": "",
18- "image": "file:///custom/usr/lib/arm-linux-gnueabihf/unity/scopes/scope-tourism-mockweather/images/overcast.png",
19+ "link": "http://www.weather.com",
20+ "image": "file://@SCOPE_INSTALL_DIR@/images/overcast.png",
21 "description": "Minimum temperature: 8°\nMaximum temperature: 14°\nChance of rain: 0%\n Wind: WSW at 16 km/h\nHumidity: 73%\nUV index: 3"
22 },
23 {
24 "title": "Tomorrow night",
25 "subtitle": "7°C",
26- "link": "",
27- "image": "file:///custom/usr/lib/arm-linux-gnueabihf/unity/scopes/scope-tourism-mockweather/images/few-clouds-night.png",
28+ "link": "http://www.weather.com",
29+ "image": "file://@SCOPE_INSTALL_DIR@/images/few-clouds-night.png",
30 "description": "Minimum temperature: 8°\nMaximum temperature: 14°\nChance of rain: 0%\n Wind: W at 14 km/h\nHumidity: 76%\nUV index: 0"
31 }
32 ]
33
34=== modified file 'debian/changelog'
35--- debian/changelog 2014-05-13 21:09:26 +0000
36+++ debian/changelog 2014-06-03 21:26:01 +0000
37@@ -1,3 +1,10 @@
38+unity-scope-tourism-shanghai-mockweather (0.7) UNRELEASED; urgency=medium
39+
40+ * Add fake links to results to cope with API requirements (LP: #1322337)
41+ * Use install path CMake variable to populate image paths
42+
43+ -- Scott Sweeny <scott.sweeny@canonical.com> Tue, 03 Jun 2014 16:38:24 -0400
44+
45 unity-scope-tourism-shanghai-mockweather (0.6) utopic; urgency=medium
46
47 * i18n fixes

Subscribers

People subscribed via source and target branches

to all changes: