Merge lp:~savilerow-team/savilerow/remove-unused-dconf into lp:savilerow

Proposed by Chris Wayne
Status: Merged
Merged at revision: 11
Proposed branch: lp:~savilerow-team/savilerow/remove-unused-dconf
Merge into: lp:savilerow
Diff against target: 25 lines (+0/-9)
1 file modified
src/system/custom/etc/dconf_source/db/custom.d/custom.key (+0/-9)
To merge this branch: bzr merge lp:~savilerow-team/savilerow/remove-unused-dconf
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Review via email: mp+218715@code.launchpad.net

Description of the change

Remove dconf keys that don't make sense to set anymore

To post a comment you must log in.
Revision history for this message
Chris Wayne (cwayne) wrote :

Tested by building/deploying/running savvy-tailor test on a flo

Revision history for this message
Scott Sweeny (ssweeny) wrote :

8 -[org/gnome/desktop/background]
9 -picture-uri='file:///custom/usr/share/backgrounds/ringtel_wallpaper_plain.png'

I thought the plan was for the wallpaper to peek through the little gap between the scope and header.

18 -[com/canonical/unity/dash]
19 -scopes=['applications.scope', 'music.scope', 'home.scope', 'video.scope', 'ebooks.scope']

Do we have an ETA on when we'll be able to set "favorites"?

review: Needs Information
Revision history for this message
Chris Wayne (cwayne) wrote :

I haven't been able to get a straight answer re: the wallpaper peeking through and customizations there. My thinking is that currently having this dconf key set would lead people to believe that the background would be shown, which it is not. My feeling is that we should add it back in once the actual support for it has landed in the image.

No ETA on when favorites are going to work, or how they will be named in dconf. I'll try to push this more to the unity team to try to get some more solid answers.

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Good enough. Changes look fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/system/custom/etc/dconf_source/db/custom.d/custom.key'
2--- src/system/custom/etc/dconf_source/db/custom.d/custom.key 2014-03-06 16:14:03 +0000
3+++ src/system/custom/etc/dconf_source/db/custom.d/custom.key 2014-05-07 22:38:00 +0000
4@@ -1,9 +1,6 @@
5 # if the keys have uppercase letters, make them lowercase here, for
6 # example com.canonical.Unity.Lenses -> com/canonical/unity/lenses
7
8-[org/gnome/desktop/background]
9-picture-uri='file:///custom/usr/share/backgrounds/ringtel_wallpaper_plain.png'
10-
11 [com/ubuntu/touch/sound]
12 incoming-call-sound='/custom/usr/share/sounds/ubuntu/stereo/ring.mp3'
13 incoming-message-sound='/custom/usr/share/sounds/ubuntu/stereo/sms.mp3'
14@@ -12,12 +9,6 @@
15 [com/canonical/unity/launcher]
16 favorites=['application://dialer-app.desktop', 'application://messaging-app.desktop', 'application://address-book-app.desktop', 'application://webbrowser-app.desktop', 'application://gallery-app.desktop', 'application://camera-app.desktop', 'application://ubuntu-system-settings.desktop', 'application://com.ubuntu.developer.mfisch.ringtel_ringtel_0.3']
17
18-[com/canonical/unity/dash]
19-scopes=['applications.scope', 'music.scope', 'home.scope', 'video.scope', 'ebooks.scope']
20-
21-[com/canonical/unity/lenses]
22-disabled-scopes=['recipes-recipepuppy.scope']
23-
24 [com/canonical/UserMetrics]
25 theme='custom'
26

Subscribers

People subscribed via source and target branches

to all changes: