Merge lp:~sao/unity-lens-files/ignore-hidden-files into lp:unity-lens-files
Proposed by
Oliver Sauder
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 171 | ||||
Proposed branch: | lp:~sao/unity-lens-files/ignore-hidden-files | ||||
Merge into: | lp:unity-lens-files | ||||
Diff against target: |
23 lines (+10/-2) 1 file modified
src/daemon.vala (+10/-2) |
||||
To merge this branch: | bzr merge lp:~sao/unity-lens-files/ignore-hidden-files | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+59299@code.launchpad.net |
Description of the change
Before files are appended to result model checking if there are not hidden.
To post a comment you must log in.
This looks mostly good. One catch though is that with the new check we stat() each file twice; first in g_file_ query_exists( ) and then afterwards in g_file_ query_info( ).
If you just drop the file.query_exists() clause and put a continue statement in the catch clause (removing the warning) I think we'll have equivalent behaviour as before while adding the hidden check to that, all still with one stat() only.