lp:~sao/nux/cursor-blink

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:nux at revision 362

Jay Taoko (community): Approve on 2011-06-14

Diff: 155 lines (+46/-16)

2 files modified

Nux/TextEntry.cpp (+40/-10)
Nux/TextEntry.h (+6/-6)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #730273: Search cursor in Unity’s Dash, File Places and Application Places search field should blink on focus

Undecided

Fix Released

Link a bug report

Related blueprints

363. By Oliver Sauder on 2011-06-03

When gaining focus cursor should be at the same position as when we lost focus

362. By Oliver Sauder on 2011-06-03

Stop cursor when destroying

361. By Oliver Sauder on 2011-06-03

Hide cursor when losing focus

360. By Oliver Sauder on 2011-06-01

Correctly remember state of focus

359. By Oliver Sauder on 2011-06-01

Layout needs to be reset for hiding and showing cursor

358. By Oliver Sauder on 2011-06-01

Commented out not implemented method

357. By Oliver Sauder on 2011-06-01

Merged branch cursor-blink from Greggory Hernandez

356. By Daniel van Vugt on 2011-05-31

Fix an X11 Display leak, causing window leaks and graphics corruption (LP: #769957)

Details:

Fixed an X11 Display leak, which caused Window leaks of the XInputWindows for the Unity panel and launcher. This created graphics corruption each time the Unity plugin restarted (other plugins toggled).

Possibly also fixed other window/resource leaks in nux/unity which were side effects of the same display leak.

Technical notes:

1. The Window objects being leaked are the _window members of XInputWindow used by BaseWindow::m_input_window. While the destructor of XInputWindow does correctly call XDestroyWindow for these, they are still leaked because the DestroyWindow request never reaches the X server. That's because XDestroyWindow only queues the destroy request and does not guarantee it has or will be completed. The display parameter to XDestroyWindow is the display being leaked, and as such never flushes or completes any of its pending requests such as the destroy request.

2. Given technical note #1, it is likely that a simpler workaround for this window leak problem would be to add an XFlush call to the end of XInputWindow::~XInputWindow(). That would be a simpler, more benign and compatible fix for bug 769957, however that would not fix the display leak which is the root cause of the problem. This merge proposal fixes all related leaks by removing the Display leak, which then causes the leaking windows to be destroyed also.

355. By Jay Taoko on 2011-05-31

* Removed unnecessary assertion in NThreadLocalStorage::RegisterTLS. Fixed returned result.
* Added NThreadLocalStorage::UnRegisterTLS

354. By Jay Taoko on 2011-05-30

* Object::Dispose() now does the same thing as Object::UnReference()
* Fixed memory leak in UXTheme::Load2DTextureFile
* Mesh Resource manager
    - Fixed mesh Resource manager pipeline
    - See example ProgObjMeshLoader

* Fixed GLSL Shaders in FontRendering.cpp
    - removed global variable USE_ARB_SHADERS and replaced with GraphicsEngine::UsingGLSLCodePath()

* Removing files IniFile.cpp/.h
* Removing files UIColorTheme.cpp/.h