Merge lp:~sao/compiz/spread_windows_workspace into lp:~compiz/compiz/ubuntu

Proposed by Oliver Sauder
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp:~sao/compiz/spread_windows_workspace
Merge into: lp:~compiz/compiz/ubuntu
Diff against target: 52 lines (+32/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/087_new_scale_defaults.patch (+23/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~sao/compiz/spread_windows_workspace
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Disapprove
Review via email: mp+66201@code.launchpad.net

Description of the change

This fixes the issue that the window spread will only show applications on the current workspace.
It does this basically by changing the default key Super+S to the option initiate_output_key.

See branch lp:~sao/unity/spread_windows_workspace which fixes the issue that app spread only shows applications on the current workspace.

Not sure if this should be merged before Bug 690143 is fixed as well.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Olivier,

Thanks for your patch:

However, I'm afraid that the bug report isn't actually about changing that. I think that "When performing a window spread" refers to initiatize the spread only from the launcher icon, not any shortcut.

The shortcut decision has been made by the design team. You can have a look at debian/changelog where I document every changes (you can check easily! ;)). See bug #723273 for the actual discussion.

In a nutshell, to fix this bug, there is some code involved in unity, from the launcher click, and not for the shortcut itself which behave as intended by design. I think that's what you have done in your other merge request, so that's nice ;)

I'll then put the merge as rejected. Do not hesitate to propose any other merge for compiz/unity of course :)

review: Disapprove
Revision history for this message
Oliver Sauder (sao) wrote :

Well, I thought this change was a bit strange to have two different changes in one bug.
Was good practice anyway ;).

Thanks for the changelog hint. Alt+Shift+Up is actually used for this. Good to know ;).

Unmerged revisions

620. By Oliver Sauder

* debian/patches/087_new_scale_defaults.patch:
  - Default key Super+W now set to only spread windows of
    current workspace (LP: #689733)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-24 08:46:02 +0000
3+++ debian/changelog 2011-06-28 19:48:40 +0000
4@@ -1,3 +1,11 @@
5+compiz (1:0.9.4+bzr20110606-0ubuntu5) natty; urgency=low
6+
7+ * debian/patches/087_new_scale_defaults.patch:
8+ - Default key Super+W now set to only spread windows of
9+ current workspace (LP: #689733)
10+
11+ -- Oliver Sauder <os@esite.ch> Tue, 28 Jun 2011 21:17:04 +0200
12+
13 compiz (1:0.9.4+bzr20110606-0ubuntu4) oneiric; urgency=low
14
15 * debian/patches/00_bzr_fix_727143.patch:
16
17=== added file 'debian/patches/087_new_scale_defaults.patch'
18--- debian/patches/087_new_scale_defaults.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/087_new_scale_defaults.patch 2011-06-28 19:48:40 +0000
20@@ -0,0 +1,23 @@
21+## Description: add some description
22+## Origin/Author: add some origin or author
23+## Bug: bug URL
24+Index: compiz-0.9.4+bzr20110606/plugins/scale/scale.xml.in
25+===================================================================
26+--- compiz-0.9.4+bzr20110606.orig/plugins/scale/scale.xml.in 2011-06-28 21:16:59.952641805 +0200
27++++ compiz-0.9.4+bzr20110606/plugins/scale/scale.xml.in 2011-06-28 21:16:53.192608366 +0200
28+@@ -138,7 +138,6 @@
29+ <option name="initiate_all_key" type="key">
30+ <_short>Initiate Window Picker For All Windows</_short>
31+ <_long>Layout and start transforming all windows</_long>
32+- <default>&lt;Super&gt;w</default>
33+ </option>
34+ <option name="initiate_group_edge" type="edge">
35+ <_short>Initiate Window Picker For Window Group</_short>
36+@@ -165,6 +164,7 @@
37+ <option name="initiate_output_key" type="key">
38+ <_short>Initiate Window Picker For Windows on Current Output</_short>
39+ <_long>Layout and start transforming windows on current output</_long>
40++ <default>&lt;Super&gt;w</default>
41+ </option>
42+ <option name="show_desktop" type="bool">
43+ <_short>Click Desktop to Show Desktop</_short>
44
45=== modified file 'debian/patches/series'
46--- debian/patches/series 2011-06-24 08:45:59 +0000
47+++ debian/patches/series 2011-06-28 19:48:40 +0000
48@@ -6,3 +6,4 @@
49 060_move_checks_to_compiz.patch
50 065_add_bailer_and_detection_plugins.patch
51 086_new_grid_defaults.patch
52+087_new_scale_defaults.patch

Subscribers

People subscribed via source and target branches

to all changes: