Merge ~santoshbit2007/oxide:overlay_scrollbar_color into oxide:master

Proposed by Santosh on 2016-11-18
Status: Merged
Approved by: Chris Coulson on 2016-11-18
Approved revision: c75d4b4b0fc4c63d83d39a1b595e45184cbeba5f
Merge reported by: Santosh
Merged at revision: not available
Proposed branch: ~santoshbit2007/oxide:overlay_scrollbar_color
Merge into: oxide:master
Diff against target: 11 lines (+1/-0)
1 file modified
shared/renderer/oxide_content_renderer_client.cc (+1/-0)
Reviewer Review Type Date Requested Status
Chris Coulson 2016-11-18 Approve on 2016-11-18
Review via email: mp+311278@code.launchpad.net

Description of the change

By default layer_tree_setting solid_color scrollbar color is white which is propogated to
Impl Tree and Impl tree draw solid color scrollbar as white

So I am overriding the the layer setting in oxide_content_renderer_client

To post a comment you must log in.
Chris Coulson (chrisccoulson) wrote :

Thanks, please merge this (can you ensure that the changelog description references the bug number as well please. You can use the format LP: #1639241)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/shared/renderer/oxide_content_renderer_client.cc b/shared/renderer/oxide_content_renderer_client.cc
2index 8829392..934c19b 100644
3--- a/shared/renderer/oxide_content_renderer_client.cc
4+++ b/shared/renderer/oxide_content_renderer_client.cc
5@@ -156,6 +156,7 @@ void ContentRendererClient::OverrideCompositorSettings(
6 settings->scrollbar_fade_delay = base::TimeDelta::FromMilliseconds(300);
7 settings->scrollbar_fade_resize_delay = base::TimeDelta::FromSeconds(2);
8 settings->scrollbar_fade_duration = base::TimeDelta::FromMilliseconds(300);
9+ settings->solid_color_scrollbar_color = SkColorSetARGB(128, 128, 128, 128);
10 }
11 }
12

Subscribers

People subscribed via source and target branches

to all changes: