Code review comment for ~santoshbit2007/oxide:scrollbar_work

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks, I've left some comments inline.

Also, this appears to still rely on GetFormFactor() to add --enable-overlay-scrollbar to the commandline, but I really want to get rid of that (bug 1548304).

And I'd prefer not to expose ShellMode to the renderer side - I'd rather we just exposed the desired scrollbar configuration

review: Needs Fixing

« Back to merge proposal