Code review comment for ~santoshbit2007/oxide:GetShellMode_Implementation

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks, I've left a few comments inline.

This does also need to be optional at build time - I don't mind if this is a build option or an automatic check (there are some CMake macros that could help here, eg https://cmake.org/cmake/help/v3.0/module/CheckCXXSymbolExists.html)

review: Needs Fixing

« Back to merge proposal