Merge lp:~santi698/gazette/fix-long-text into lp:gazette

Proposed by Santiago Ocamica
Status: Merged
Merged at revision: 58
Proposed branch: lp:~santi698/gazette/fix-long-text
Merge into: lp:gazette
Diff against target: 42 lines (+10/-2)
3 files modified
src/Services/Files.vala (+1/-1)
src/Services/News.vala (+1/-1)
src/Services/Service.vala (+8/-0)
To merge this branch: bzr merge lp:~santi698/gazette/fix-long-text
Reviewer Review Type Date Requested Status
Eduard Gotwig Pending
Review via email: mp+160788@code.launchpad.net

Description of the change

Ellipsizes long strings.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/Files.vala'
2--- src/Services/Files.vala 2013-04-22 19:06:09 +0000
3+++ src/Services/Files.vala 2013-04-25 04:04:27 +0000
4@@ -44,7 +44,7 @@
5 files_list.reactive = false;
6 var res = "<span font='12' face='Open Sans'>";
7 for (var i = 0; i < 10 && i < last_files.length (); i++) {
8- res += last_files.nth_data (i).get_display_name () + "\n";
9+ res += ellipsize (last_files.nth_data (i).get_display_name (), 40) + "\n";
10 }
11 files_list.label = res + "</span>";
12 files_list.reactive = true;
13
14=== modified file 'src/Services/News.vala'
15--- src/Services/News.vala 2013-04-22 19:06:09 +0000
16+++ src/Services/News.vala 2013-04-25 04:04:27 +0000
17@@ -76,7 +76,7 @@
18 var title = output.substring (offset, output.index_of ("</title>", offset) - offset);
19 offset = output.index_of ("<link>", offset) + 6;
20 var url = output.substring (offset, output.index_of ("</link>", offset) - offset);
21- news[i] = {title, url};
22+ news[i] = {ellipsize(title, 40), url};
23 }
24 var list = "<span font='12' face='Open Sans'>";
25 for (var i = 0; i < news.length; i++) {
26
27=== modified file 'src/Services/Service.vala'
28--- src/Services/Service.vala 2013-04-22 19:06:09 +0000
29+++ src/Services/Service.vala 2013-04-25 04:04:27 +0000
30@@ -124,4 +124,12 @@
31 {
32 animate (Clutter.AnimationMode.LINEAR, 400, opacity : 255);
33 }
34+
35+ public static string ellipsize (string s, int max_length) {
36+ string ret = s;
37+ if (ret.length > max_length)
38+ ret = ret.substring (0, ret.index_of_nth_char(max_length-3)) + "...";
39+ debug(ret);
40+ return ret;
41+ }
42 }

Subscribers

People subscribed via source and target branches