Code review comment for lp:~sandy-walsh/nova/zones4

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Thanks rick ... great feedback. I've implemented your changes.

re: get_diagnostics, the name in the decorator is the name of the method in novaclient, so it may not map 1:1 to the method being wrapped (as in this case).

Basically the decorator is saying, "if this method can't find the instance, check with the child zones by calling <method> in novaclient"

« Back to merge proposal