Code review comment for lp:~sandy-walsh/nova/zones

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi! Great work so far, Sandy.

A couple notes:

1) 223 === added file 'nova/db/sqlalchemy/migrate_repo/versions/003_cactus.py'

I think we wanted to go with >1 migrate scripts per release, with a migration script for each patch that makes changes to the underlying database schema.

So, I'd recommend s/003_cactus.py/003_add_zone_tables.py/.

2) Looks like you are still calling things child zones in the migration script and in the nova.db.api docstrings...

Other than those little things, lgtm.

review: Needs Fixing

« Back to merge proposal