OpenStack Compute (nova)

Merge lp:~sandy-walsh/nova/LP718869-pt2 into lp:~hudson-openstack/nova/trunk

  1. LP718869-pt2
  2. Merge into trunk
Proposed by Sandy Walsh
Status: Merged
Approved by: Devin Carlen
Approved revision: 928
Merged at revision: 930
Proposed branch: lp:~sandy-walsh/nova/LP718869-pt2
Merge into: lp:~hudson-openstack/nova/trunk
Diff against target: 12 lines (+0/-2)
1 file modified
nova/rpc.py (+0/-2)
To merge this branch: bzr merge lp:~sandy-walsh/nova/LP718869-pt2
Reviewer Review Type Date Requested Status
Devin Carlen (community) Approve
Vish Ishaya (community) Approve
Review via email: mp+55817@code.launchpad.net

Description of the change

Removes excessive logging message in the event of a rabbitmq failure.

Pro: logs stay under control
Con: in the event of a non-comm failure, the exception will get eaten.

To post a comment you must log in.
Revision history for this message
Vish Ishaya (vishvananda) wrote :

Thx sandy, LGTM

review: Approve
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/rpc.py'
2--- nova/rpc.py 2011-03-30 15:29:17 +0000
3+++ nova/rpc.py 2011-03-31 19:37:18 +0000
4@@ -134,8 +134,6 @@
5 if not self.failed_connection:
6 LOG.exception(_("Failed to fetch message from queue: %s" % e))
7 self.failed_connection = True
8- else:
9- LOG.exception(_("Unhandled exception %s" % e))
10
11 def attach_to_eventlet(self):
12 """Only needed for unit tests!"""