Merge lp:~samuel-thibault/compiz/plugin-load-order into lp:compiz/0.9.13

[Samuel thibault]

compizconfig: load modules in alphabetical order instead of undefined order

This makes compiz load plugins in alphabetical order instead of undefined order, which brings variability on the varying systems of users, and thus potential bugs that users will see and developers won't see.

[Samuel thibault (samuel-thibault)]

(of course it lets dependencies fix the ordering, I just mean that independent modules get loaded in alphabetical order).

[Marco Trevisan (Treviño) (3v1n0)]

Well, the order isn't really undefined, as it has constrains defined by dependencies... If none needs a plugin is true that there's no order, but it shouldn't affect things.

However I think this won't cause any trouble, but at least we can guess better what will happen

review: Approve

=== modified file 'compizconfig/libcompizconfig/src/main.c'
--- compizconfig/libcompizconfig/src/main.c	2014-04-07 22:36:52 +0000
+++ compizconfig/libcompizconfig/src/main.c	2017-10-31 17:27:44 +0000
@@ -3012,6 +3012,15 @@
     CCSPluginList after;
 } PluginSortHelper;
 
+static int
+PluginCompare (const void *_a, const void *_b)
+{
+    const PluginSortHelper *a = _a;
+    const PluginSortHelper *b = _b;
+
+    return strcmp (ccsPluginGetName (a->plugin), ccsPluginGetName (b->plugin));
+}
+
 CCSStringList
 ccsGetSortedPluginStringListDefault (CCSContext * context)
 {
@@ -3052,6 +3061,9 @@
 	plugins[i].after = NULL;
     }
 
+    /* Sort alphabetically first, to get a stable order. */
+    qsort (plugins, len, sizeof (PluginSortHelper), PluginCompare);
+
     for (i = 0; i < len; ++i)
     {
 	CCSStringList l = ccsPluginGetLoadAfter (plugins[i].plugin);