Merge lp:~samuel-taylor/ubuntu/oneiric/pidgin-skype/fix-for-657125 into lp:ubuntu/oneiric/pidgin-skype

Proposed by Samuel Taylor
Status: Work in progress
Proposed branch: lp:~samuel-taylor/ubuntu/oneiric/pidgin-skype/fix-for-657125
Merge into: lp:ubuntu/oneiric/pidgin-skype
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~samuel-taylor/ubuntu/oneiric/pidgin-skype/fix-for-657125
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Micah Gersten (community) Needs Fixing
Ubuntu branches Pending
Review via email: mp+75701@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Micah Gersten (micahg) wrote :

Thank you for contributing to Ubuntu development. Sorry, but due to the way the archives work, you cannot depend on a partner package from multiverse. At best, you could recommend it since recommends are nice to have (and installed by default), but won't prevent installation if they're not available (i.e. partner not enabled).

review: Needs Fixing
Revision history for this message
Micah Gersten (micahg) wrote :

Also, please keep in mind that since this package is maintained in Debian (and most people using this package will have skype installed anyways), if the Debian maintainer won't take the diff for this recommends/suggests on skype, then it will be dropped when the next Debian upload is sync'd. This would be nice to have, but isn't worth the maintenance burden IMHO. You might want to check with the Debian maintainer first (http://packages.qa.debian.org/p/pidgin-skype.html).

Revision history for this message
Micah Gersten (micahg) wrote :

Oh, also an enhances on skype would work as well.

Revision history for this message
Luke Yelavich (themuso) :
review: Needs Fixing

Unmerged revisions

9. By Samuel Taylor

debian/control: updated depends to include skype (LP: #657125)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-07-30 23:14:29 +0000
3+++ debian/changelog 2011-09-16 10:21:59 +0000
4@@ -1,3 +1,9 @@
5+pidgin-skype (20110407+svn612+dfsg-1ubuntu2) oneiric; urgency=low
6+
7+ * debian/control: updated depends to include skype (LP: #657125)
8+
9+ -- Samuel Taylor <samtaylor.uk@gmail.com> Fri, 16 Sep 2011 11:10:15 +0100
10+
11 pidgin-skype (20110407+svn612+dfsg-1ubuntu1) oneiric; urgency=low
12
13 * Use pkg-config to find glib and dbus include paths (LP: #756174)
14
15=== modified file 'debian/control'
16--- debian/control 2011-07-30 23:14:29 +0000
17+++ debian/control 2011-09-16 10:21:59 +0000
18@@ -32,7 +32,7 @@
19 Section: contrib/debug
20 Priority: extra
21 Architecture: i386 amd64
22-Depends: ${misc:Depends}, pidgin-skype (= ${binary:Version})
23+Depends: ${misc:Depends}, pidgin-skype (= ${binary:Version}), skype
24 Description: Skype plugin for libpurple messengers (debug symbols)
25 This protocol plugin allows libpurple to communicate with Skype.
26 Applications using libpurple (Pidgin, Finch, Empathy/Telepathy,

Subscribers

People subscribed via source and target branches

to all changes: