Merge lp:~samuel-buffet/entertainer/eyeD3_exception_proof_indexer into lp:entertainer

[Samuel Buffet]

EyeD3 exceptions have been fixed.

[Samuel Buffet (samuel-buffet)]

Hi,

Since the time we've removed all try/except in the code, the backend refuses to index my music contents properly.

The traceback I've added in the bug report Bug #366368 demonstrates that the eyeD3 module we use to extract mp3 tags is crashing.

This is why I think we should reintroduce a try/except there waiting for the new indexer that Paul is working on.

Samuel-

[Matt Layman (mblayman)]

I'm okay with this since most (if not all) of this code will be going away when the new indexer comes into play.

review: Approve

=== modified file 'entertainerlib/backend/components/mediacache/music_cache.py'
--- entertainerlib/backend/components/mediacache/music_cache.py	2009-02-07 21:43:35 +0000
+++ entertainerlib/backend/components/mediacache/music_cache.py	2009-04-24 20:41:49 +0000
@@ -250,8 +250,12 @@
             - Get tags
             - Insert data to the music cache database
         """
-        mp3_file = eyeD3.Mp3AudioFile(filename, eyeD3.ID3_ANY_VERSION)
-        tags = mp3_file.getTag()
+        try:
+            mp3_file = eyeD3.Mp3AudioFile(filename, eyeD3.ID3_ANY_VERSION)
+            tags = mp3_file.getTag()
+        except:
+            self.logger.error("Couldn't read ID3tags: " + filename)
+            return
 
         if tags is None:
             self.logger.error("Couldn't read ID3tags: " + filename)