Merge lp:~samertm/ubuntu-webcatalog/fixes-1278515 into lp:ubuntu-webcatalog

Proposed by Samer Masterson
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp:~samertm/ubuntu-webcatalog/fixes-1278515
Merge into: lp:ubuntu-webcatalog
Diff against target: 12 lines (+1/-1)
1 file modified
src/webcatalog/templates/webcatalog/application_review_list_snippet.html (+1/-1)
To merge this branch: bzr merge lp:~samertm/ubuntu-webcatalog/fixes-1278515
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Canonical Consumer Applications Hackers Pending
Review via email: mp+205815@code.launchpad.net

Commit message

 * Inserts newlines in review text html

Description of the change

 * Inserts newlines in review text html

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your merge proposal!

This looks good to me and this is similar to what software-center is doing.

Could someone from the webui team please double check :) ?

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist.
Change status again if this MP is still current.

Unmerged revisions

197. By Samer Masterson

* Inserts newlines in review texts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webcatalog/templates/webcatalog/application_review_list_snippet.html'
2--- src/webcatalog/templates/webcatalog/application_review_list_snippet.html 2011-09-15 13:54:52 +0000
3+++ src/webcatalog/templates/webcatalog/application_review_list_snippet.html 2014-02-11 16:47:43 +0000
4@@ -8,7 +8,7 @@
5 </div>
6 {% rating_summary review.rating %}
7 <strong>{{ review.summary }}</strong>
8- <p>{{ review.review_text }}</p>
9+ <p>{{ review.review_text|linebreaksbr }}</p>
10 <p class="usefulness">
11 {% blocktrans with favorable=review.usefulness_favorable total=review.usefulness_total %}
12 {{ favorable }} out of {{ total }} found this review helpful.

Subscribers

People subscribed via source and target branches