Merge lp:~samertm/ubuntu-calendar-app/fixes-1272625 into lp:ubuntu-calendar-app
Proposed by
Samer Masterson
Status: | Merged |
---|---|
Approved by: | David Planella |
Approved revision: | 189 |
Merged at revision: | 190 |
Proposed branch: | lp:~samertm/ubuntu-calendar-app/fixes-1272625 |
Merge into: | lp:ubuntu-calendar-app |
Diff against target: |
43 lines (+4/-4) 2 files modified
DayView.qml (+3/-3) WeekView.qml (+1/-1) |
To merge this branch: | bzr merge lp:~samertm/ubuntu-calendar-app/fixes-1272625 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
David Planella | Approve | ||
Victor Thompson (community) | Approve | ||
Review via email: mp+203448@code.launchpad.net |
Commit message
* Changes the height of the frame to fit the window.
* Moves "anchors.fill: parent" into the Column scope in
DayView.qml to keep it consistent with WeekView.qml
Description of the change
Changes the height so that it's relative to the top of the view path, so that it will still be correct if the heights of the other views are changed.
There is no need for spacing because "anchors.fill: parent" was moved from the Item scope to the Column scope in DayView.qml. This keeps the anchors in DayView and WeekView consistent.
To post a comment you must log in.
Looks right on my device. Nice work!