lp:samba

Branch merges

1 branch proposed for merging into this one.

Related source package recipes

3 recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

55383. By Andreas Schneider <email address hidden> 9 hours ago

s3:smbcontrol: Simplify the return code check

Signed-off-by: Andreas Schneider <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>

Autobuild-User(master): Jeremy Allison <email address hidden>
Autobuild-Date(master): Sat Oct 20 02:17:56 CEST 2018 on sn-devel-144

55382. By Andreas Schneider <email address hidden> 12 hours ago

s4:torture: Fix the scope of the req variable in drsuapi test

Found by covscan.

Signed-off-by: Andreas Schneider <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>

55381. By Andreas Schneider <email address hidden> 12 hours ago

ndr: Init variables of GUID_from_data_blob()

Found by covscan.

Signed-off-by: Andreas Schneider <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>

55380. By Andreas Schneider <email address hidden> 12 hours ago

s3:registry: Avoid a double-free in reg_perfcount

Found by covscan.

Signed-off-by: Andreas Schneider <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>

55379. By David Disseldorp 12 hours ago

talloc: deprecate talloc_set_memlimit()

The memlimit functionality was never utilized by Samba. It adds unneeded
complexity, so flag it as deprecated.

Signed-off-by: David Disseldorp <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>

55378. By Volker Lendecke <email address hidden> 16 hours ago

lib: Remove gencache.h from proto.h

It's a pain to recompile the world if gencache.h changes

Signed-off-by: Volker Lendecke <email address hidden>
Reviewed-by: Andreas Schneider <email address hidden>

Autobuild-User(master): Andreas Schneider <email address hidden>
Autobuild-Date(master): Fri Oct 19 18:52:50 CEST 2018 on sn-devel-144

55377. By Whatever 21 hours ago

s3:secrets: clean up sid before storing

SIDs may contain non-zero memory beyond SubAuthorityCount:

    {
    key(15) = "SECRETS/SID/FOO"
    data(68) = "\01\04\00\00\00\00\00\05\15\00\00\00}u@\8C\08\A3\06nx\95\16\FE\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00`F\92\B7\03\00\00\00\18e\92\B7\03\00\00\00@H\92\B7\00\00\00\00"
    }

These parts are lost when converting to ``string format syntax``
so a roundtrip conversion does not result in the same binary
representation.

Ensure that these never reach the tdb by using an initialized
copy. This allows bitwise comparisons of secrets.tdb after
dumping SIDs as text and reading them back.

Signed-off-by: Philipp Gesang <email address hidden>
Reviewed-by: Volker Lendecke <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

Autobuild-User(master): Andrew Bartlett <email address hidden>
Autobuild-Date(master): Fri Oct 19 13:59:04 CEST 2018 on sn-devel-144

55376. By Gary Lockyer <email address hidden> on 2018-10-19

dsdb encrypted_secrets: Allow "ldb:// and "mdb://" in file path

Correctly handle "ldb://" and "mdb://" schemes in the file path when
determining the path for the encrypted secrets key file.

When creating a new user and specifying the local file path of the
sam.ldb DB, it was possible to create an account that you could not
login with. The path for the key file was incorrectly calculated
for the "ldb://" and "mdb://" schemes, the scheme was not stripped from
the path and the subsequent open of the key file failed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653

Signed-off-by: Gary Lockyer <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

Autobuild-User(master): Andrew Bartlett <email address hidden>
Autobuild-Date(master): Fri Oct 19 09:34:46 CEST 2018 on sn-devel-144

55375. By Gary Lockyer <email address hidden> on 2018-10-19

dsdb encrypted_secrets tests: Allow "ldb://" in file path

When creating a new user and specifying the local file path of the
sam.ldb DB, it's possible to create an account that you can't actually
login with.

This commit contains tests to verify the bug.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13653

Signed-off-by: Gary Lockyer <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

55374. By Gary Lockyer <email address hidden> on 2018-10-19

python tests Blackbox: add random_password

Add the random_password method to the BlackboxTestCase class and remove
duplicated copies from other test cases. Also use SystemRandom so that
the generated passwords are more cryptographically sound.

Signed-off-by: Gary Lockyer <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>