lp:samba

Branch merges

1 branch proposed for merging into this one.

Related source package recipes

3 recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

54479. By Tim Beale <email address hidden> on 2018-08-15

netcmd: Fix --kerberos=yes and --no-secrets domain backups

The --kerberos=yes and --no-secrets options didn't work in combination
for domain backups. The problem was creds.get_username() might not
necessarily match the kerberos user (such as in the selftest
environment). If this was the case, then trying to reset the admin
password failed (because the creds.get_username() didn't exist in
the DB).

Because the admin user always has a fixed RID, we can work out the
administrator based on its object SID, instead of relying on the
username in the creds.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

Autobuild-User(master): Andrew Bartlett <email address hidden>
Autobuild-Date(master): Wed Aug 15 10:19:09 CEST 2018 on sn-devel-144

54478. By Tim Beale <email address hidden> on 2018-08-15

netcmd: Delete unnecessary function

Minor code cleanup. The last 2 patches gutted this function, to the
point where there's no longer any value in keeping it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54477. By Tim Beale <email address hidden> on 2018-08-15

netcmd: Fix kerberos option for domain backups

The previous fix still didn't work if you specified --kerberos=yes (in
which case the creds still doesn't have a password).

credopts.get_credentials(lp) should be enough to ensure a user/password
is set (it's all that the other commands seem to do).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54476. By Tim Beale <email address hidden> on 2018-08-15

netcmd: domain backup didn't support prompting for password

The online/rename backups only worked if you specified both the username
and password in the actual command itself. If you just entered the
username (expecting to be prompted for the password later), then the
command was rejected.

The problem was the order the code was doing things in. We were checking
credopts.creds.get_password() *before* we'd called
credopts.get_credentials(lp), whereas it should be the other way
around.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566

Signed-off-by: Tim Beale <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54475. By Timur I. Bakeyev <email address hidden> on 2018-08-15

third_party:build: Test for the flags, recognized by Clang.

Make amd64 SYSTEM_UNAME_MACHINE an alias for x86_64.

Signed-off-by: Timur I. Bakeyev <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54474. By Joe Guo <email address hidden> on 2018-08-15

emulate/traffic: add sAMAccountName in create_group

While using script/traffic_replay to generate users and groups, we get
autogenerated group name like:

    $2A6F42B2-39FAF4556E2BE379

This patch specify sAMAccountName to overwriten the name.

Signed-off-by: Joe Guo <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54473. By Joe Guo <email address hidden> on 2018-08-15

traffic-replay: add extra check

Make sure --average-groups-per-user is not more than --number-of-users

Signed-off-by: Joe Guo <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54472. By Joe Guo <email address hidden> on 2018-08-15

traffic: uniform stats output

The original code is trying to output different data format for tty or file.
This is unnecessary and cause confusion while writing script to parse result.

The human-readable one is also easy for code to parse.
Remove if check for isatty(), just make output the same.

Signed-off-by: Joe Guo <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54471. By Joe Guo <email address hidden> on 2018-08-15

emulate/traffic: fix next usage

In commit b0c9de820c07d77c03b80505cb811ac1dac0808f, line 343:

    self.next_conversation_id = itertools.count().next

was changed to:

    self.next_conversation_id = next(itertools.count())

which is not correct, the first one is a function, the second one is a
int. This patch fixed it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13573

Signed-off-by: Joe Guo <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>

54470. By Joe Guo <email address hidden> on 2018-08-15

samba-tool/drs: set dns_backend to SAMBA_INTERNAL in cmd_drs_clone_dc_database

The default value is "NONE", need to specify it to use SAMBA_INTERNAL so
that the DNS partitions are replicated.

Signed-off-by: Joe Guo <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>
Reviewed-by: Douglas Bagnall <email address hidden>