lp:samba

Branch merges

1 branch proposed for merging into this one.

Related source package recipes

3 recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

66213. By Volker Lendecke <email address hidden> on 2021-03-03

vfs_aixacl2: Fix "mem_ctx" and "ppdesc" smb_fget_nt_acl_nfs4 args

Signed-off-by: Volker Lendecke <email address hidden>
Reviewed-by: Björn Jacke <email address hidden>

Autobuild-User(master): Björn Jacke <email address hidden>
Autobuild-Date(master): Wed Mar 3 12:36:13 UTC 2021 on sn-devel-184

66212. By Björn Jacke <email address hidden> on 2021-03-03

wscript: use --as-needed only if tested successfully

Some OSes like Solaris based OmiOS don't support this.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14288

Signed-off-by: Bjoern Jacke <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66211. By Trever Adams on 2021-03-01

s3:modules:vfs_virusfilter: Recent talloc changes cause infinite start-up failure

Recent talloc changes cause the current check for failure to allocate to be incorrectly triggered.

This patch ensures the original parameter is not NULL before attempting any talloc or strstr.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14634
RN: Fix failure of vfs_virusfilter starting due to talloc changes

Signed-off-by: Trever L. Adams" <email address hidden>
Reviewed-by: Jeremy Allison <email address hidden>
Reviewed-by: Noel Power <email address hidden>

Autobuild-User(master): Noel Power <email address hidden>
Autobuild-Date(master): Mon Mar 1 21:44:55 UTC 2021 on sn-devel-184

66210. By Jelmer Vernooij on 2021-03-01

Suggest running './configure' rather than 'waf configure'.

waf actively discourages system-wide waf installs, so the latter is unlikely
to work.

Signed-off-by: Jelmer Vernooij <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

Autobuild-User(master): Andrew Bartlett <email address hidden>
Autobuild-Date(master): Mon Mar 1 04:56:15 UTC 2021 on sn-devel-184

66209. By Samuel Cabrero <email address hidden> on 2021-03-01

daemons: Do not notify systemd in child processes started by main samba

When samba runs as ADDC only the main 'samba' daemon have to notify
its status to systemd because our systemd unit files contains implied
NotifyAccess=main since commit d1740fb3d5a72cb49e30b330bb0b01e7ef3e09cc.

This commit adds a function to disable the systemd notification in the
smbd and winbinddd child processes started by the main 'samba' daemon in
AD DC mode to avoid warnings like:

systemd[1]: samba-ad-dc.service: Got notification message from PID 26194,
     but reception only permitted for main PID 26187
systemd[1]: samba-ad-dc.service: Got notification message from PID 26222,
     but reception only permitted for main PID 26187

$ pstree -p
...
├─samba(26187)─┬─tfork(26189)(26188)───s3fs[master](26189)───tfork(26194)(26193)───smbd(26194)─┬─cleanupd(+
│ │ ├─lpqd(2623+
│ │ └─smbd-noti+
│ ├─tfork(26191)(26190)───rpc[master](26191)─┬─tfork(26198)(26195)───rpc(0)(26198)
│ │ ├─tfork(26200)(26199)───rpc(1)(26200)
│ │ ├─tfork(26206)(26201)───rpc(2)(26206)
│ │ └─tfork(26212)(26207)───rpc(3)(26212)
│ ├─tfork(26196)(26192)───nbt[master](26196)
│ ├─tfork(26202)(26197)───wrepl[master](26202)
│ ├─tfork(26204)(26203)───ldap[master](26204)─┬─tfork(26242)(26241)───ldap(0)(26242)
│ │ ├─tfork(26244)(26243)───ldap(1)(26244)
│ │ ├─tfork(26246)(26245)───ldap(2)(26246)
│ │ └─tfork(26248)(26247)───ldap(3)(26248)
│ ├─tfork(26208)(26205)───cldap[master](26208)
│ ├─tfork(26210)(26209)───kdc[master](26210)───tfork(26218)(26215)───krb5kdc(26218)
│ ├─tfork(26213)(26211)───drepl[master](26213)
│ ├─tfork(26216)(26214)───winbindd[master(26216)───tfork(26222)(26219)───winbindd(26222)───wi+
│ ├─tfork(26220)(26217)───ntp_signd[maste(26220)
│ ├─tfork(26223)(26221)───kcc[master](26223)
│ ├─tfork(26225)(26224)───dnsupdate[maste(26225)
│ └─tfork(26227)(26226)───dns[master](26227)

Signed-off-by: Samuel Cabrero <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66208. By Samuel Cabrero <email address hidden> on 2021-03-01

lib:util: Move variable initialization out of conditional compilation block

Signed-off-by: Samuel Cabrero <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66207. By Björn Baumbach <email address hidden> on 2021-03-01

test: samba-tool user show: Test ';format=[GeneralizedTime,UnixTime,TimeSpec] attributes

Pair-Programmed-With: Stefan Metzmacher <email address hidden>

Signed-off-by: Björn Baumbach <email address hidden>
Signed-off-by: Stefan Metzmacher <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66206. By Stefan Metzmacher on 2021-03-01

samba-tool user: add ';format=[GeneralizedTime,UnixTime,TimeSpec]' support in "samba-tool user show"

This is useful to convert various time values to other formats.

Pair-Programmed-With: Björn Baumbach <email address hidden>

Signed-off-by: Stefan Metzmacher <email address hidden>
Signed-off-by: Björn Baumbach <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66205. By Stefan Metzmacher on 2021-03-01

samba-tool user: add ';format=[GeneralizedTime,UnixTime,TimeSpec]' support

These are useful to convert various time values to other formats.

Pair-Programmed-With: Björn Baumbach <email address hidden>

Signed-off-by: Stefan Metzmacher <email address hidden>
Signed-off-by: Björn Baumbach <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>

66204. By Stefan Metzmacher on 2021-03-01

samba-tool user: use an implicit_attrs list instead of add_ATTR variables

We'll extent GetPasswordCommand.get_password_attributes() to handle
more virtual formats in future. It'll be much easier to
to maintain a list of attributes we need to filter out again.

sAMAccountName and userPrincipalName are always implicitly
requested in order to keep the existing code sane.

supplementalCredentials and unicodePwd are requested by default
when generating virtual password attributes.

Pair-Programmed-With: Björn Baumbach <email address hidden>

Signed-off-by: Stefan Metzmacher <email address hidden>
Signed-off-by: Björn Baumbach <email address hidden>
Reviewed-by: Andrew Bartlett <email address hidden>