Merge lp:~sam92/openlp/bug-1552563-2.4 into lp:openlp/2.4
Proposed by
Samuel Mehrbrodt
Status: | Merged |
---|---|
Approved by: | Tim Bentley |
Approved revision: | 2629 |
Merged at revision: | 2628 |
Proposed branch: | lp:~sam92/openlp/bug-1552563-2.4 |
Merge into: | lp:openlp/2.4 |
Diff against target: |
68 lines (+17/-18) 2 files modified
openlp/plugins/songs/lib/mediaitem.py (+17/-17) tests/functional/openlp_plugins/songs/test_openlpimporter.py (+0/-1) |
To merge this branch: | bzr merge lp:~sam92/openlp/bug-1552563-2.4 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Approve | ||
Raoul Snyman | Approve | ||
Review via email: mp+293429@code.launchpad.net |
Description of the change
Fix performance regression with Songbook search
The problem was that in each iteration the database was accessed (the song object).
Fixed this by loading all neccessary information directly in the query.
Also this reintroduces natural sorting.
To post a comment you must log in.
lp:~sam92/openlp/bug-1552563-2.4 (revision 2629) /ci.openlp. io/job/ Branch- 01-Pull/ 1510/ /ci.openlp. io/job/ Branch- 02-Functional- Tests/1421/ /ci.openlp. io/job/ Branch- 03-Interface- Tests/1359/ /ci.openlp. io/job/ Branch- 04a-Windows_ Functional_ Tests/1155/ /ci.openlp. io/job/ Branch- 04b-Windows_ Interface_ Tests/746/ /ci.openlp. io/job/ Branch- 05a-Code_ Analysis/ 813/ /ci.openlp. io/job/ Branch- 05b-Test_ Coverage/ 681/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/