Online Accounts setup for Ubuntu Touch

Merge lp:~sam-sgrs/ubuntu-system-settings-online-accounts/ubuntu-system-settings-online-accounts_1553771 into lp:ubuntu-system-settings-online-accounts

Proposed by Sam Segers on 2016-03-06

Status:

Needs review

Proposed branch:

Merge into:

Diff against target:

1 file modified

plugins/module/OAuth.qml (+1/-1)

To merge this branch:

bzr merge lp:~sam-sgrs/ubuntu-system-settings-online-accounts/ubuntu-system-settings-online-accounts_1553771

Undecided

New

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alberto Mardegan (community)		2016-03-06	Needs Fixing on 2016-05-23
Review via email: mp+288223@code.launchpad.net

Revision history for this message

Alberto Mardegan (mardy) wrote on 2016-05-23:

Sorry Sam, for some reason I completely missed this merge request.

Looks good, just please remove the space before the ")", to be consistent with the rest of the code.

review: Needs Fixing

332. By Sam Segers on 2016-03-06: Add error message to the output of onAuthenticationError
331. By Launchpad Translations on behalf of online-accounts on 2016-02-29: Launchpad automatic translations update.
330. By Launchpad Translations on behalf of online-accounts on 2016-02-28: Launchpad automatic translations update.

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'plugins/module/OAuth.qml'
2	--- plugins/module/OAuth.qml 2015-11-02 07:28:44 +0000
3	+++ plugins/module/OAuth.qml 2016-03-06 18:27:04 +0000
4	@@ -228,7 +228,7 @@
5	onAuthenticated: completeCreation(reply)
6
7	onAuthenticationError: {
8	- console.log("Authentication error, code " + error.code)
9	+ console.log("Authentication error, code " + error.code + ", message:" + error.message )
10	if (error.code == AccountService.NetworkError) {
11	console.log("Network error")
12	errorItem.visible = true