Code review comment for lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487

Revision history for this message
Sam Segers (sam-sgrs) wrote :

This *should* fix having to remove the libs on the system itself discussed
in the link you gave.
But I can't test this on a device (that's why I fixed it for the desktop so
I could try the content store in Unity8).
So maybe it's better if someone else tries it?

Op wo 24 aug. 2016 06:39 schreef Sam Segers <email address hidden>:

> No. I didn't.
> I'll check this later today.
>
> Op wo 24 aug. 2016 00:49 schreef Carlos Jose Mazieri <
> <email address hidden>>:
>
> > Review: Needs Information
> >
> > Hello Sam,
> >
> > It is OK to me, just a question:
> >
> > Have you tested building for armf on device and building for armf on
> > qtcreator using a sdk like click-ubuntu-sdk-13.10-armhf?
> >
> > This build was done by Alan Pope and Stefano Verzegnassi to prevent a bug
> > that did not allow to install libsmbclien-dev in armf sdk, see
> >
> https://code.launchpad.net/~popey/ubuntu-filemanager-app/add-click-deps/+merge/270287
> > .
> > --
> >
> >
> https://code.launchpad.net/~sam-sgrs/ubuntu-filemanager-app/fix-1579487/+merge/303622
> > You are the owner of lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487.
> >
>
> --
>
> https://code.launchpad.net/~sam-sgrs/ubuntu-filemanager-app/fix-1579487/+merge/303622
> You are the owner of lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487.
>

« Back to merge proposal