Merge lp:~saltmakrell/ubuntu/trusty/osm-gps-map/fixtiles-osm-gps-map into lp:ubuntu/trusty/osm-gps-map

Proposed by Ruben Undheim
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~saltmakrell/ubuntu/trusty/osm-gps-map/fixtiles-osm-gps-map
Merge into: lp:ubuntu/trusty/osm-gps-map
Diff against target: 74 lines (+36/-1)
5 files modified
debian/changelog (+7/-0)
debian/patches/02-fix_type_for_amd64.patch (+11/-0)
debian/patches/03-wrong_user_agent.patch (+13/-0)
debian/patches/series (+2/-0)
debian/rules (+3/-1)
To merge this branch: bzr merge lp:~saltmakrell/ubuntu/trusty/osm-gps-map/fixtiles-osm-gps-map
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Ubuntu branches Pending
Review via email: mp+223774@code.launchpad.net

Description of the change

Fixes both #1312890 and #1320359.
This fix is needed for osm-gps-map to behave as required by openstreetmap (not sending fake User-Agent in the HTTP request).

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Looking good, fixes the FTBFS properly and seems to be a correct backport of the utopic-proposed user-agent fix.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

setting as merged, it's uploaded

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-07-10 09:01:42 +0000
3+++ debian/changelog 2014-06-19 15:37:46 +0000
4@@ -1,3 +1,10 @@
5+osm-gps-map (0.7.3-3ubuntu1) trusty; urgency=low
6+
7+ * Fixing "failing to build from source (FTBFS)" (LP: #1312890)
8+ * Fix for invalid user-agent (LP: #1320359)
9+
10+ -- Ruben Undheim <ruben.undheim@gmail.com> Thu, 19 Jun 2014 17:22:23 +0200
11+
12 osm-gps-map (0.7.3-3) unstable; urgency=low
13
14 * Add missing dependency on python-gtk2 (Closes: #680815)
15
16=== added file 'debian/patches/02-fix_type_for_amd64.patch'
17--- debian/patches/02-fix_type_for_amd64.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/02-fix_type_for_amd64.patch 2014-06-19 15:37:46 +0000
19@@ -0,0 +1,11 @@
20+--- osm-gps-map-0.7.3.orig/src/osm-gps-map-widget.c
21++++ osm-gps-map-0.7.3/src/osm-gps-map-widget.c
22+@@ -775,7 +775,7 @@ osm_gps_map_tile_download_complete (Soup
23+ if (file != NULL) {
24+ fwrite (MSG_RESPONSE_BODY(msg), 1, MSG_RESPONSE_LEN(msg), file);
25+ file_saved = TRUE;
26+- g_debug("Wrote "MSG_RESPONSE_LEN_FORMAT" bytes to %s", MSG_RESPONSE_LEN(msg), dl->filename);
27++ g_debug("Wrote "MSG_RESPONSE_LEN_FORMAT" bytes to %s", (long long int)MSG_RESPONSE_LEN(msg), dl->filename);
28+ fclose (file);
29+
30+ }
31
32=== added file 'debian/patches/03-wrong_user_agent.patch'
33--- debian/patches/03-wrong_user_agent.patch 1970-01-01 00:00:00 +0000
34+++ debian/patches/03-wrong_user_agent.patch 2014-06-19 15:37:46 +0000
35@@ -0,0 +1,13 @@
36+Index: osm-gps-map-0.7.3/src/osm-gps-map-widget.c
37+===================================================================
38+--- osm-gps-map-0.7.3.orig/src/osm-gps-map-widget.c 2014-05-16 21:11:48.853708626 +0200
39++++ osm-gps-map-0.7.3/src/osm-gps-map-widget.c 2014-05-16 21:12:18.825708575 +0200
40+@@ -143,7 +143,7 @@
41+ #define ENABLE_DEBUG (0)
42+ #define EXTRA_BORDER (TILESIZE / 2)
43+ #define OSM_GPS_MAP_SCROLL_STEP (10)
44+-#define USER_AGENT "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11"
45++#define USER_AGENT "libosmgpsmap/0.7.3"
46+ #define DOWNLOAD_RETRIES 3
47+ #define MAX_DOWNLOAD_TILES 10000
48+
49
50=== modified file 'debian/patches/series'
51--- debian/patches/series 2011-12-31 11:16:10 +0000
52+++ debian/patches/series 2014-06-19 15:37:46 +0000
53@@ -1,1 +1,3 @@
54 01-fix_python_linking.patch
55+02-fix_type_for_amd64.patch
56+03-wrong_user_agent.patch
57
58=== modified file 'debian/rules'
59--- debian/rules 2012-06-27 09:22:21 +0000
60+++ debian/rules 2014-06-19 15:37:46 +0000
61@@ -15,10 +15,12 @@
62 --disable-introspection \
63 --enable-gtk-doc \
64 --enable-gtk-doc-html \
65- --enable-gtk-doc-pdf
66+ --enable-gtk-doc-pdf \
67+ --prefix=/usr
68
69 override_dh_auto_install:
70 for py in $(shell pyversions -r); do \
71+ cd python && gnome-autogen.sh && cd .. ; \
72 PYTHON=$$py dh_auto_configure -Dpython/; \
73 dh_auto_build -Dpython/; \
74 dh_auto_install -Dpython/; \

Subscribers

People subscribed via source and target branches

to all changes: