Merge lp:~salgado/ubuntu-community-webthemes/ubuntu-logo-to-css into lp:ubuntu-community-webthemes/light-django-theme

Proposed by Guilherme Salgado
Status: Merged
Approved by: Michael Hall
Approved revision: 33
Merged at revision: 33
Proposed branch: lp:~salgado/ubuntu-community-webthemes/ubuntu-logo-to-css
Merge into: lp:ubuntu-community-webthemes/light-django-theme
Diff against target: 41 lines (+7/-6)
2 files modified
media/css/default.css (+6/-5)
templates/ubuntu_website_base.html (+1/-1)
To merge this branch: bzr merge lp:~salgado/ubuntu-community-webthemes/ubuntu-logo-to-css
Reviewer Review Type Date Requested Status
Ubuntu Community Web Themes Developers Pending
Review via email: mp+58385@code.launchpad.net

Description of the change

Move the URL for the Ubuntu logo from the base template to css so that it can be more easily replaced

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'media/css/default.css'
2--- media/css/default.css 2011-03-14 19:11:05 +0000
3+++ media/css/default.css 2011-04-19 20:30:59 +0000
4@@ -288,10 +288,6 @@
5 width: 180px;
6 }
7
8-#the-logo {
9- float: right
10-}
11-
12 #page-related {
13 background-image: none;
14 margin: 0 auto;
15@@ -631,7 +627,12 @@
16 }
17
18 #the-logo {
19- padding-left: 4px
20+ background: url("http://www.ubuntu.com/sites/default/themes/ubuntu10/logo.png");
21+ width: 118px;
22+ height: 27px;
23+ display: block;
24+ clear: both;
25+ float: right
26 }
27
28 #loco {
29
30=== modified file 'templates/ubuntu_website_base.html'
31--- templates/ubuntu_website_base.html 2011-03-10 01:38:25 +0000
32+++ templates/ubuntu_website_base.html 2011-04-19 20:30:59 +0000
33@@ -72,7 +72,7 @@
34 </nav>
35 <h1 id="top-logo">
36 <a href="{% block logo_href %}/{% endblock %}">
37- {% block logo_img %}<img class="png" id="the-logo" src="http://www.ubuntu.com//sites/default/themes/ubuntu10/logo.png" alt="Ubuntu" width="118" height="27" />{% endblock %}
38+ {% block logo_img %}<span id="the-logo"></span>{% endblock %}
39 <span id="loco">{% block logo_text %}Country Loco Team{% endblock %}</span>
40 </a>
41 </h1>

Subscribers

People subscribed via source and target branches