Merge lp:~salgado/offspring/remove-more-dead-code into lp:offspring

Proposed by Guilherme Salgado
Status: Merged
Approved by: Cody A.W. Somerville
Approved revision: 85
Merged at revision: 86
Proposed branch: lp:~salgado/offspring/remove-more-dead-code
Merge into: lp:offspring
Diff against target: 41 lines (+0/-24)
1 file modified
lib/offspring/web/queuemanager/models.py (+0/-24)
To merge this branch: bzr merge lp:~salgado/offspring/remove-more-dead-code
Reviewer Review Type Date Requested Status
Cody A.W. Somerville Approve
Review via email: mp+77217@code.launchpad.net

Description of the change

Remove 4 unused methods: 3 from ProjectGroup and 1 from Project

To post a comment you must log in.
Revision history for this message
Cody A.W. Somerville (cody-somerville) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/offspring/web/queuemanager/models.py'
2--- lib/offspring/web/queuemanager/models.py 2011-02-22 09:46:13 +0000
3+++ lib/offspring/web/queuemanager/models.py 2011-09-27 18:45:28 +0000
4@@ -110,24 +110,6 @@
5 return ">1 Day"
6 return "UNKNOWN"
7
8- def latest_build(self):
9- try:
10- return BuildResult.objects.filter(project__project_group = self).exclude(result = None).exclude(started_at = None).latest()
11- except self.model.DoesNotExist:
12- return None
13-
14- def latest_build_name(self):
15- try:
16- return self.latest_build().name
17- except self.model.DoesNotExist:
18- return u""
19-
20- def latest_build_date(self):
21- try:
22- return self.latest_build().started_at
23- except self.model.DoesNotExist:
24- return u""
25-
26
27 class Project(models.Model):
28 #XXX: This should probably be managed in the database.
29@@ -202,12 +184,6 @@
30 except self.model.DoesNotExist:
31 return None
32
33- def latest_build_name(self):
34- try:
35- return self.latest_build().name
36- except self.model.DoesNotExist:
37- return u""
38-
39 def latest_build_date(self):
40 try:
41 return self.latest_build().started_at

Subscribers

People subscribed via source and target branches