Merge lp:~salgado/offspring/builds-view into lp:offspring

[Guilherme Salgado]

Change the builds() view to show private builds if the user is allowed to see them

[lp:~salgado/offspring/builds-view]

102. By Guilherme Salgado on 2011-12-02

Add docstrings to test methods

[Kevin McDermott (bigkevmcd)]

Looks ok to me...

Some trailing whitespace...and

+ if p is not None and p.is_private:

How about fixing this to project rather than "p"

If you use vim...

highlight SpecialKey ctermbg=red ctermfg=black guibg=red guifg=black
set list
set listchars=trail:\ ,tab:>-,nbsp:%

Will highlight trailing whitespace

review: Approve

[lp:~salgado/offspring/builds-view]

103. By Guilherme Salgado on 2011-12-14

merge trunk

104. By Guilherme Salgado on 2011-12-14

A few cosmetic fixes suggested by Kevin

[Guilherme Salgado (salgado)]

On Wed, 2011-12-14 at 11:34 +0000, Kevin McDermott wrote:
> Review: Approve
>
> Looks ok to me...
>
> Some trailing whitespace...and

I've fixed only the ones in the view I touched to avoid conflicts with
the other branches that are still pending.

>
> + if p is not None and p.is_private:
>
> How about fixing this to project rather than "p"

Yep, fixed.

>
> If you use vim...
>
> highlight SpecialKey ctermbg=red ctermfg=black guibg=red guifg=black
> set list
> set listchars=trail:\ ,tab:>-,nbsp:%
>
> Will highlight trailing whitespace

That's very handy, thanks! And thanks for the review as well.