Merge lp:~salgado/linaro-image-tools/use-cmd-runner into lp:linaro-image-tools/11.11

[Guilherme Salgado]

Update a couple modules using subprocess.Popen() when they should use
cmd_runner.run.

[Martin Ohlsson (martin-ohlson)]

No problems there.

/Martin

review: Approve

=== modified file 'media_create/remove_binary_dir.py'
--- media_create/remove_binary_dir.py	2010-12-01 09:06:53 +0000
+++ media_create/remove_binary_dir.py	2010-12-15 11:41:54 +0000
@@ -1,16 +1,13 @@
-#!/usr/bin/python
-
 import sys
 import os.path
-import subprocess
+
+from media_create import cmd_runner
+
 
 def remove_binary_dir(binary_dir='binary/', as_root=True):
     if os.path.exists(binary_dir):
-        args = []
-        if as_root:
-            args.extend(['sudo'])
-        args.extend(['rm', '-rf', binary_dir])
-        proc = subprocess.Popen(args)
+        proc = cmd_runner.run(
+            ['rm', '-rf', binary_dir], as_root=as_root)
         proc.wait()
         return proc.returncode
     return 0

=== modified file 'media_create/unpack_binary_tarball.py'
--- media_create/unpack_binary_tarball.py	2010-11-27 08:27:20 +0000
+++ media_create/unpack_binary_tarball.py	2010-12-15 11:41:54 +0000
@@ -1,17 +1,15 @@
-#!/usr/bin/python
-
 import sys
-import subprocess
+
+from media_create import cmd_runner
+
 
 def unpack_binary_tarball(tarball, as_root=True):
-    args = []
-    if as_root:
-        args.extend(['sudo'])
-    args.extend(['tar', '--numeric-owner', '-xf', tarball])    
-    proc = subprocess.Popen(args)
+    proc = cmd_runner.run(
+        ['tar', '--numeric-owner', '-xf', tarball], as_root=as_root)
     proc.wait()
     return proc.returncode
 
+
 if __name__ == '__main__':
     if len(sys.argv) != 2:
         print 'usage: ' + sys.argv[0] + ' <BINARY_TARBALL>'