Merge lp:~salgado/linaro-image-tools/bug-702650 into lp:linaro-image-tools/11.11

Proposed by Guilherme Salgado
Status: Merged
Merged at revision: 239
Proposed branch: lp:~salgado/linaro-image-tools/bug-702650
Merge into: lp:linaro-image-tools/11.11
Diff against target: 0 lines
To merge this branch: bzr merge lp:~salgado/linaro-image-tools/bug-702650
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+46203@code.launchpad.net

Description of the change

Use UDisks to lookup the correct device files for the boot/root partitions.

Unfortunately, doing so via UDisks is not as straightforward as I'd like
because there's no method to get a given partition from a device, so I need
to get all device files that represent partitions on the device selected by
the user, get the UDisks.Device object for them and check the partition
number.

Another alternative would be to just list the device files that represent a
partition on the selected device and get the one whose last char matches the
partition number, but that sounds a bit too fragile to me even though I doubt
it would ever become a problem.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Hi,

Should we report a bug about the deficiency in udisks here?

The change looks good though.

Thanks,

James

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

This fixes it up for me

240. By Guilherme Salgado

Add a comment mentioning the UDisks bug I've reported

Revision history for this message
Guilherme Salgado (salgado) wrote :

I've filed https://bugs.freedesktop.org/show_bug.cgi?id=33113 and mentioned that in a comment around that code.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches