Merge lp:~salgado/launchpad/remove-policy_options into lp:launchpad

Proposed by Guilherme Salgado
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: no longer in the source branch.
Merged at revision: 11065
Proposed branch: lp:~salgado/launchpad/remove-policy_options
Merge into: lp:launchpad
Diff against target: 54 lines (+0/-34)
2 files modified
lib/lp/archiveuploader/uploadpolicy.py (+0/-31)
scripts/process-upload.py (+0/-3)
To merge this branch: bzr merge lp:~salgado/launchpad/remove-policy_options
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) code Approve
Review via email: mp+28392@code.launchpad.net

Description of the change

Remove lp.archiveuploader.uploadpolicy.policy_options, which was not used anywhere

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/archiveuploader/uploadpolicy.py'
2--- lib/lp/archiveuploader/uploadpolicy.py 2010-02-05 15:06:28 +0000
3+++ lib/lp/archiveuploader/uploadpolicy.py 2010-06-24 11:48:37 +0000
4@@ -25,37 +25,6 @@
5 HOURS = 3600
6
7
8-def policy_options(optparser):
9- """Add to the optparser all the options which can be used by the policy
10- objects herein.
11- """
12-
13- optparser.add_option(
14- "-C", "--context", action="store", dest="context",
15- metavar="CONTEXT", default="insecure",
16- help="The context in which to consider the upload.")
17-
18- optparser.add_option(
19- "-d", "--distro", action="store",
20- dest="distro", metavar="DISTRO", default="ubuntu",
21- help="Distribution to give back from")
22-
23- optparser.add_option(
24- "-s", "--series", action="store", default=None,
25- dest="distroseries", metavar="DISTROSERIES",
26- help="Distro series to give back from.")
27-
28- optparser.add_option(
29- "-b", "--buildid", action="store", type="int",
30- dest="buildid", metavar="BUILD",
31- help="The build ID to which to attach this upload.")
32-
33- optparser.add_option(
34- "-a", "--announce", action="store",
35- dest="announcelist", metavar="ANNOUNCELIST",
36- help="Override the announcement list")
37-
38-
39 class UploadPolicyError(Exception):
40 """Raised when a specific policy violation occurs."""
41
42
43=== modified file 'scripts/process-upload.py'
44--- scripts/process-upload.py 2010-04-27 19:48:39 +0000
45+++ scripts/process-upload.py 2010-06-24 11:48:37 +0000
46@@ -11,9 +11,6 @@
47
48 import _pythonpath
49
50-# XXX: This import is not actually used, but it avoids a major circular import
51-# problem. We love you too, Python.
52-from lp.archiveuploader.uploadpolicy import policy_options
53 from canonical.config import config
54 from lp.soyuz.scripts.soyuz_process_upload import ProcessUpload
55