Merge lp:~salgado/launchpad/remove-changepassword-page into lp:launchpad/db-devel

[Guilherme Salgado]

Remove the +changepassword page

Now we're an OpenID consumer, so users should be changing their password
on the OP.

--
Guilherme Salgado <email address hidden>

[Gary Poster (gary)]

Looks good. Thank you, Salgado.

You have already responded in r9076 to the following request from IRC, which I include here for completeness.

"""
do we have a bug for removing CIP? If not, please create one, and then add the fact that we need to remove IPersonChangePassword to the bug description, and then make a reference to that bug in the XXX in lib/lp/registry/interfaces/person.py, and then add an "improvement" card for removing CIP to the kanban board in the bug grabbag referring to the bug to remove CIP.
"""

Gary

review: Approve

[Francis J. Lacoste (flacoste)]

Land this on production-devel for a regular CP.

review: Approve (release-critical)

=== modified file 'lib/lp/registry/browser/configure.zcml'
--- lib/lp/registry/browser/configure.zcml	2010-02-19 11:55:02 +0000
+++ lib/lp/registry/browser/configure.zcml	2010-03-05 14:53:30 +0000
@@ -790,12 +790,6 @@
             permission="zope.Public"
             template="../templates/person-claim.pt"/>
         <browser:page
-            name="+changepassword"
-            for="lp.registry.interfaces.person.IPerson"
-            class="lp.registry.browser.person.PersonChangePasswordView"
-            permission="launchpad.Edit"
-            template="../../app/templates/generic-edit.pt"/>
-        <browser:page
             name="+editlanguages"
             for="lp.registry.interfaces.person.IPerson"
             class="lp.registry.browser.person.PersonLanguagesView"

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2010-02-25 23:29:29 +0000
+++ lib/lp/registry/browser/person.py	2010-03-05 14:53:30 +0000
@@ -20,7 +20,6 @@
     'PersonAssignedBugTaskSearchListingView',
     'PersonBrandingView',
     'PersonBugsMenu',
-    'PersonChangePasswordView',
     'PersonClaimView',
     'PersonCodeOfConductEditView',
     'PersonCommentedBugTaskSearchListingView',
@@ -149,7 +148,6 @@
 from canonical.launchpad.interfaces.gpghandler import (
     GPGKeyNotFoundError, IGPGHandler)
 from lp.services.worlddata.interfaces.language import ILanguageSet
-from canonical.launchpad.interfaces.launchpad import IPasswordEncryptor
 from canonical.launchpad.interfaces.logintoken import ILoginTokenSet
 from canonical.launchpad.interfaces.oauth import IOAuthConsumerSet
 from lp.blueprints.interfaces.specification import SpecificationFilter
@@ -165,9 +163,9 @@
 from lp.registry.interfaces.mailinglistsubscription import (
     MailingListAutoSubscribePolicy)
 from lp.registry.interfaces.person import (
-    INewPerson, IPerson, IPersonChangePassword, IPersonClaim,
-    IPersonSet, ITeam, ITeamReassignment, PersonCreationRationale,
-    PersonVisibility, TeamMembershipRenewalPolicy, TeamSubscriptionPolicy)
+    INewPerson, IPerson, IPersonClaim, IPersonSet, ITeam, ITeamReassignment,
+    PersonCreationRationale, PersonVisibility, TeamMembershipRenewalPolicy,
+    TeamSubscriptionPolicy)
 from lp.registry.interfaces.poll import IPollSet, IPollSubset
 from lp.registry.interfaces.ssh import ISSHKeySet, SSHKeyType
 from lp.registry.interfaces.teammembership import (
@@ -887,12 +885,6 @@
         return Link(target, text, icon='edit')
 
     @enabled_with_permission('launchpad.Edit')
-    def editpassword(self):
-        target = '+changepassword'
-        text = 'Change your password'
-        return Link(target, text, icon='edit')
-
-    @enabled_with_permission('launchpad.Edit')
     def edit(self):
         target = '+edit'
         text = 'Change details'
@@ -917,7 +909,7 @@
     facet = 'overview'
     links = ['edit', 'branding', 'common_edithomepage',
              'editemailaddresses', 'editlanguages', 'editwikinames',
-             'editircnicknames', 'editjabberids', 'editpassword',
+             'editircnicknames', 'editjabberids',
              'editsshkeys', 'editpgpkeys', 'editlocation', 'memberships',
              'codesofconduct', 'karma', 'administer', 'administer_account',
              'projects', 'activate_ppa', 'maintained',
@@ -1093,11 +1085,6 @@
         text = 'OpenPGP Keys'
         return Link(target, text)
 
-    def passwords(self):
-        target = '+changepassword'
-        text = 'Passwords'
-        return Link(target, text)
-
 
 class TeamMenuMixin(PPANavigationMenuMixIn, CommonMenuLinks):
     """Base class of team menus.
@@ -3881,45 +3868,6 @@
         token.sendGPGValidationRequest(key)
 
 
-class PersonChangePasswordView(LaunchpadFormView):
-
-    implements(IPersonEditMenu)
-
-    label = "Change your password"
-    schema = IPersonChangePassword
-    field_names = ['currentpassword', 'password']
-    custom_widget('password', PasswordChangeWidget)
-
-    @property
-    def next_url(self):
-        return canonical_url(self.context)
-
-    def validate(self, form_values):
-        current_password = form_values.get('currentpassword')
-        encryptor = getUtility(IPasswordEncryptor)
-        if not encryptor.validate(current_password, self.context.password):
-            self.setFieldError('currentpassword', _(
-                "The provided password doesn't match your current password."))
-        # This is not part of the widget, since the value may
-        # be optional in some forms.
-        new_password = self.request.form.get('field.password', '')
-        if new_password.strip() == '':
-            self.setFieldError('password', _(
-                "Setting an empty password is not allowed."))
-
-    @action(_("Change Password"), name="submit")
-    def submit_action(self, action, data):
-        password = data['password']
-        self.context.password = password
-        self.request.response.addInfoNotification(_(
-            "Password changed successfully"))
-
-    @property
-    def cancel_url(self):
-        """The URL that the 'Cancel' link should return to."""
-        return canonical_url(self.context)
-
-
 class BasePersonEditView(LaunchpadEditFormView):
 
     schema = IPerson
@@ -5898,8 +5846,7 @@
     usedfor = IPersonIndexMenu
     facet = 'overview'
     title = 'Change person'
-    links = ('edit', 'administer', 'administer_account',
-             'branding', 'editpassword')
+    links = ('edit', 'administer', 'administer_account', 'branding')
 
 
 class ITeamIndexMenu(Interface):

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2010-02-27 10:19:18 +0000
+++ lib/lp/registry/interfaces/person.py	2010-03-05 14:53:30 +0000
@@ -431,6 +431,9 @@
         super(PersonNameField, self)._validate(input)
 
 
+# XXX: salgado, 2010/03/05, bug=532688: This is currently used by c-i-p, so it
+# can't be removed yet.  As soon as we stop using c-i-p, though, we'll be able
+# to remove this.
 class IPersonChangePassword(Interface):
     """The schema used by Person +changepassword form."""