Merge lp:~salgado/launchpad/py2.5-teammembership into lp:~launchpad-committers/launchpad/python-migration

Proposed by Guilherme Salgado
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~salgado/launchpad/py2.5-teammembership
Merge into: lp:~launchpad-committers/launchpad/python-migration
Diff against target: 49 lines
2 files modified
lib/canonical/launchpad/webapp/breadcrumb.py (+5/-3)
lib/lp/registry/doc/teammembership.txt (+4/-8)
To merge this branch: bzr merge lp:~salgado/launchpad/py2.5-teammembership
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Canonical Launchpad Engineering Pending
Review via email: mp+13382@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

Fix a couple teammembership tests and remove some unused imports.

Revision history for this message
Barry Warsaw (barry) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/webapp/breadcrumb.py'
2--- lib/canonical/launchpad/webapp/breadcrumb.py 2009-09-18 04:06:03 +0000
3+++ lib/canonical/launchpad/webapp/breadcrumb.py 2009-10-14 20:50:23 +0000
4@@ -13,8 +13,6 @@
5 ]
6
7
8-from zope.traversing.interfaces import IPathAdapter
9-from zope.component import queryAdapter
10 from zope.interface import implements
11
12 from canonical.launchpad.webapp import canonical_url
13@@ -56,8 +54,12 @@
14 return self._url
15
16 def __repr__(self):
17+ # XXX: salgado, 2009-10-14, http://bugs.python.org/issue5876: In
18+ # python 2.5, the return value of __repr__() may be forced into a
19+ # type(str), so we can't include unicode here.
20+ text = self.text.encode('raw-unicode-escape')
21 return "<%s url='%s' text='%s'>" % (
22- self.__class__.__name__, self.url, self.text)
23+ self.__class__.__name__, self.url, text)
24
25
26 class NameBreadcrumb(Breadcrumb):
27
28=== modified file 'lib/lp/registry/doc/teammembership.txt'
29--- lib/lp/registry/doc/teammembership.txt 2009-08-13 15:12:16 +0000
30+++ lib/lp/registry/doc/teammembership.txt 2009-10-14 20:50:23 +0000
31@@ -134,14 +134,10 @@
32
33 >>> from zope.security.interfaces import Unauthorized
34 >>> mark = personset.getByName('mark')
35- >>> try:
36- ... t3.addMember(
37- ... salgado, reviewer=mark, status=TeamMembershipStatus.ADMIN)
38- ... except Unauthorized, info:
39- ... print Unauthorized, info
40- ... else:
41- ... print "No exception raised"
42- zope.security.interfaces.Unauthorized (..., 'addMember', 'launchpad.Edit')
43+ >>> t3.addMember(salgado, reviewer=mark, status=TeamMembershipStatus.ADMIN)
44+ Traceback (most recent call last):
45+ ...
46+ Unauthorized:...
47
48 # Log in as the team owner.
49 >>> login_person(t3.teamowner)

Subscribers

People subscribed via source and target branches