Merge lp:~salgado/launchpad/bug-540697 into lp:launchpad

[Guilherme Salgado]

Do not add a notification message to the request on UnauthorizedView as
the +login page (which it redirects to) is blank and will just redirect
to the OpenID provider (bug 540697)

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/webapp/login.py

== Pylint notices ==

lib/canonical/launchpad/webapp/login.py
    5: [W0105] String statement has no effect

[Paul Hummer (rockstar)]

review: Approve (code)

=== modified file 'lib/canonical/launchpad/webapp/login.py'
--- lib/canonical/launchpad/webapp/login.py	2010-03-04 14:03:34 +0000
+++ lib/canonical/launchpad/webapp/login.py	2010-03-18 15:28:31 +0000
@@ -56,8 +56,6 @@
     read_only_page = ViewPageTemplateFile(
         '../templates/launchpad-readonlyfailure.pt')
 
-    notification_message = _('To continue, you must log in to Launchpad.')
-
     def __call__(self):
         # In read only mode, Unauthorized exceptions get raised by the
         # security policy when write permissions are requested. We need
@@ -105,8 +103,6 @@
             # unauthenticated sessions. Only after this next line is it safe
             # to use the ``addNoticeNotification`` method.
             allowUnauthenticatedSession(self.request)
-            self.request.response.addNoticeNotification(
-                self.notification_message)
             self.request.response.redirect(target)
             # Maybe render page with a link to the redirection?
             return ''