Merge lp:~salgado/launchpad/bug-415977-2 into lp:launchpad
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~salgado/launchpad/bug-415977-2 |
Merge into: | lp:launchpad |
Diff against target: |
150 lines 3 files modified
database/schema/security.cfg (+1/-0) lib/canonical/launchpad/webapp/login.py (+16/-7) lib/lp/registry/stories/foaf/xx-resetpassword-of-sso-account.txt (+83/-0) |
To merge this branch: | bzr merge lp:~salgado/launchpad/bug-415977-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | Approve | ||
Review via email: mp+14187@code.launchpad.net |
To post a comment you must log in.
= Summary =
As reported on bug 415977, personless accounts can't use the
+forgottenpassword form on Launchpad because it doesn't know how to deal
with these accounts.
== Proposed fix ==
In the mailing list we discussed getting rid of LP's +forgottenpassword
and change all links to point to the same page on SSO, but that's not
possible because that page doesn't exist on SSO anymore -- they use the
login form with some javascript and a regular link to request a password
reset and we're not doing that in LP.
For that reason we had to resort to the other alternative, which is to
change the +forgottenpassword page to generate AuthTokens when the email
address is associated with a personless account.
== Pre-implementation notes ==
== Implementation details ==
== Tests ==
./bin/test -vvt resetpassword- of-sso- account. txt
== Demo and Q/A ==
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: schema/ security. cfg /launchpad/ webapp/ login.py registry/ stories/ foaf/xx- resetpassword- of-sso- account. txt
database/
lib/canonical
lib/lp/