Launchpad itself

Merge lp:~salgado/launchpad/breadcrumb-change-fallout into lp:~launchpad-committers/launchpad/python-migration

  1. breadcrumb-change-fallout
  2. Merge into python-migration
Proposed by Guilherme Salgado
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~salgado/launchpad/breadcrumb-change-fallout
Merge into: lp:~launchpad-committers/launchpad/python-migration
Diff against target: 16 lines
1 file modified
lib/canonical/launchpad/doc/hierarchical-menu.txt (+2/-4)
To merge this branch: bzr merge lp:~salgado/launchpad/breadcrumb-change-fallout
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Michael Nelson Pending
Review via email: mp+13411@code.launchpad.net

This proposal supersedes a proposal from 2009-10-15.

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote : Posted in a previous version of this proposal

Yesterday I changed Breadcrumb.__repr__() to fix some tests, but that change broke a different test. This branch fixes it.

Revision history for this message
Barry Warsaw (barry) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/doc/hierarchical-menu.txt'
2--- lib/canonical/launchpad/doc/hierarchical-menu.txt 2009-09-21 12:28:14 +0000
3+++ lib/canonical/launchpad/doc/hierarchical-menu.txt 2009-10-15 13:21:19 +0000
4@@ -177,10 +177,8 @@
5 True
6 >>> print breadcrumb.text
7 None
8- >>> breadcrumb
9- <Breadcrumb
10- url='http://launchpad.dev/joy-of-cooking'
11- text='None'>
12+ >>> print breadcrumb.url
13+ http://launchpad.dev/joy-of-cooking
14
15 As said above, the breadcrumb's attributes can be overridden with subclassing
16 and Python properties.

Subscribers

People subscribed via source and target branches