Merge lp:~salgado/launchpad-work-items-tracker/use-new-workitems-lp-property into lp:launchpad-work-items-tracker

Proposed by Guilherme Salgado
Status: Merged
Merged at revision: 292
Proposed branch: lp:~salgado/launchpad-work-items-tracker/use-new-workitems-lp-property
Merge into: lp:launchpad-work-items-tracker
Diff against target: 21 lines (+9/-2)
1 file modified
collect (+9/-2)
To merge this branch: bzr merge lp:~salgado/launchpad-work-items-tracker/use-new-workitems-lp-property
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+96799@code.launchpad.net

Description of the change

This changes the collect script to pull work items from both the whiteboard and the new work-items field. It can be deployed now because it will just skip the new field if it doesn't exist.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'collect'
2--- collect 2012-03-06 15:23:49 +0000
3+++ collect 2012-03-09 17:45:23 +0000
4@@ -216,8 +216,15 @@
5 model_bp, model_bp.milestone_name, collector.lp, people_cache=people_cache,
6 error_collector=error_collector)
7
8- if bp.workitems_text:
9- for l in bp.workitems_text.splitlines():
10+ # Get work items from both the whiteboard and the new workitems_text
11+ # property. Once the migration is completed and nobody's using the
12+ # whiteboard for work items we can change this to pull work items only
13+ # from bp.workitems_text.
14+ workitems_text = bp.whiteboard
15+ if getattr(bp, 'workitems_text', '') != '':
16+ workitems_text += "\n" + bp.workitems_text
17+ if workitems_text:
18+ for l in workitems_text.splitlines():
19 if not in_workitems_block:
20 m = work_items_re.search(l)
21 if m:

Subscribers

People subscribed via source and target branches

to all changes: